Asterisk
  1. Asterisk
  2. ASTERISK-18201

Asterisk should fall back to AVP when SRTP module is not loaded and both SAVP and AVP have been offered

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 1.8.5.0
    • Target Release Version/s: None
    • Security Level: None
    • Labels:
      None
    • Environment:
      Asterisk 1.8.5, Nortel NSR
    • Frequency of Occurrence:
      Constant
    • SVN Revision Number:
      329894

      Description

      When both SRTP and RTP (RTP/AVP and RTP/SAVP) are offered Asterisk should fall back to the RTP protocol if it fails to load the SRTP module. Up until 1.6 Asterisk ignored the SRTP requests and - if available - would fall back to RTP; this is a regression test failure in an environment where SRTP is not to be used, even if it's offered.

      This is a sample INVITE SDP content of such type:

      v=0
      o=- 189845755 1 IN IP4 XXX.XXX.XXX.XXX
      s=-
      t=0 0
      m=audio 5262 RTP/AVP 0 8 101 111
      c=IN IP4 XXX.XXX.XXX.XXX
      a=rtpmap:101 telephone-event/8000
      a=fmtp:101 0-15
      a=rtpmap:111 X-nt-inforeq/8000
      a=ptime:20
      a=maxptime:20
      a=sendrecv
      m=audio 5262 RTP/SAVP 8 0 101 111
      c=IN IP4 XXX.XXX.XXX.XXX
      a=crypto:1 AES_CM_128_HMAC_SHA1_80 inline:dnUo0FOvQmZF+QJqoT/JlsrcyjFyiDZe5IDM/V 6V|2^031|003007014426:004
      a=rtpmap:101 telephone-event/8000
      a=fmtp:101 0-15
      a=rtpmap:111 X-nt-inforeq/8000
      a=ptime:20
      a=maxptime:20
      a=sendrecv

        Issue Links

          Activity

          No builds found.
          Fabio Torchetti created issue -
          Hide
          Fabio Torchetti added a comment -


          First approach to solve the issue. Keep track of offered AVP and use that if SAVP fails.

          Show
          Fabio Torchetti added a comment - First approach to solve the issue. Keep track of offered AVP and use that if SAVP fails.
          Fabio Torchetti made changes -
          Field Original Value New Value
          Attachment fallback_srtp.patch [ 40781 ]
          Hide
          Gregory Hinton Nietsky added a comment -

          Please see ASTERISK-17895 id like to work this into the patch im busy with there

          https://reviewboard.asterisk.org/r/1173/

          Thank You

          Show
          Gregory Hinton Nietsky added a comment - Please see ASTERISK-17895 id like to work this into the patch im busy with there https://reviewboard.asterisk.org/r/1173/ Thank You
          Hide
          Fabio Torchetti added a comment -

          I'm looking into it, it would be good to get your patch resolve both issues at the same time.

          Show
          Fabio Torchetti added a comment - I'm looking into it, it would be good to get your patch resolve both issues at the same time.
          Leif Madsen made changes -
          Status Triage [ 10000 ] Open [ 1 ]
          Leif Madsen made changes -
          Link This issue is the original version of this clone: ASTERISK-18386 [ ASTERISK-18386 ]
          Hide
          Tomo Takebe added a comment -

          By the way, I noticed that the patch checks for

          if ( clear_video_offered )

          during the audio part. This should be:

          if ( clear_audio_offered )

          Show
          Tomo Takebe added a comment - By the way, I noticed that the patch checks for if ( clear_video_offered ) during the audio part. This should be: if ( clear_audio_offered )
          Matt Jordan made changes -
          Remote Link This issue links to "SWP-3739 (Digium JIRA Internal)" [ 14243 ]
          Matt Jordan made changes -
          Link This issue is duplicated by ASTERISK-22675 [ ASTERISK-22675 ]
          Matt Jordan made changes -
          Link This issue is duplicated by ASTERISK-23989 [ ASTERISK-23989 ]
          Hide
          Matt Jordan added a comment -

          Closing this out as a duplicate of ASTERISK-23989. The patch on this issue should be compared with Olle's when it is put up for peer review.

          Show
          Matt Jordan added a comment - Closing this out as a duplicate of ASTERISK-23989 . The patch on this issue should be compared with Olle's when it is put up for peer review.
          Matt Jordan made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Duplicate [ 3 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Triage Triage Open Open
          33d 9h 11m 1 Leif Madsen 30/Aug/11 3:37 PM
          Open Open Closed Closed
          1292d 8h 21m 1 Matt Jordan 14/Mar/15 11:59 PM

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development