[Home]

Summary:ASTERISK-18255: [regression] Non-portable SQL added to app_voicemail
Reporter:Leif Madsen (lmadsen)Labels:
Date Opened:2011-08-11 09:24:36Date Closed:2011-09-06 08:56:40
Priority:BlockerRegression?Yes
Status:Closed/CompleteComponents:Applications/app_voicemail/ODBC
Versions:1.4.42 1.6.2.20 1.8.5.0 Frequency of
Occurrence
Related
Issues:
must be completed before resolvingASTERISK-18393 Asterisk 1.8.7.0 Blockers
is related toASTERISK-18257 Develop automated test for SQL portability in Asterisk
Environment:Attachments:
Description:Revision 312212 introduced a regression in app_voicemail where it breaks ODBC voicemail when the backend is MSSQL.

Line 3450 of apps/app_voicemail.c has this line:

               snprintf(sql, sizeof(sql), "SELECT msgnum FROM %s WHERE dir=? order by msgnum desc limit 1", odbc_table);

The 'limit 1' is not portable to all SQL backends, and should be removed.
Comments:By: Leif Madsen (lmadsen) 2011-09-19 11:34:25.222-0500

r334453 | irroot | 2011-09-06 08:48:03 -0500 (Tue, 06 Sep 2011) | 13 lines