| Summary: | ASTERISK-18288: peer->mvipvt needs locking | ||
| Reporter: | Olle Johansson (oej) | Labels: | |
| Date Opened: | 2011-08-18 06:13:41 | Date Closed: | 2011-09-12 08:26:40 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | 1.8.5.0 10.0.0-beta1 | Frequency of Occurrence | Occasional |
| Related Issues: | |||
| Environment: | Linux | Attachments: | |
| Description: | Historically, mwi was sent by one thread (monitor) and did not need any locking. With the addition of event driven MWI, we now have two threads, the event thread and the monitor thread for retransmits, that work on the same pvt. We have had multiple crashes in 1.6.0 caused by fights over the sip history linked list and memory corruption when removing entries (when the list overflows). Looking at it, we realized that no locking was done so the two threads where allowed to have fun with the same pvt at the same time. | ||
| Comments: | |||