Summary:	ASTERISK-18454: Option for Read to be able to accept #
Reporter:	Sta Retji (staretji)	Labels:	patch
Date Opened:	2011-09-07 13:01:55	Date Closed:	2021-09-01 10:30:52
Priority:	Trivial	Regression?
Status:	Closed/Complete	Components:	Applications/app_read
Versions:		Frequency of Occurrence
Related Issues:	is duplicated by ASTERISK-29615 app_read: Allow reading the digit #
Environment:		Attachments:	( 0) app_read_hash-11-err.patch ( 1) app_read_hash-11v2.patch
Description:	At this moment exten => 1,1,Read(digits,,1) can read number digit only. It would be awesome to have option to accept # digit.
Comments:	By: Birger "WIMPy" Harzenetter (wimpy) 2011-09-07 18:36:14.619-0500 Attached patch adds parameter h (hash) to accept # as a digit instead of terminating input. Useful e.g. to do a DTMF test extension. By: Birger "WIMPy" Harzenetter (wimpy) 2012-11-05 19:47:26.974-0600 Updated patch for Asterisk 11 By: Matt Jordan (mjordan) 2013-01-28 12:21:41.819-0600 Since it was mentioned in #asterisk today... A few comments on the patch: # Clean up the [coding guidelines|https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines] stuff. There's some spaces needed here and there, and a few {} missing around one liners. # I agree that we should warn a user when they attempt to use Read with the Hash option and no timeout or maxdigits; I also think we should just bail. The alternative is the caller ends up in a fairly long holding pattern where all they can do is mash DTMF. That's bad. I'd prefer to force the dialplan writer to fix their error. By: Birger "WIMPy" Harzenetter (wimpy) 2013-02-22 22:11:04.967-0600 Cleaned up version of the patch By: Birger "WIMPy" Harzenetter (wimpy) 2013-02-23 08:59:55.735-0600 ... and a version that barfs out By: Birger "WIMPy" Harzenetter (wimpy) 2015-07-22 15:20:42.435-0500 Removed the oldest patches and added a cleaned up version By: Friendly Automation (friendly-automation) 2021-09-01 10:30:54.456-0500 Change 16424 merged by George Joseph: app_read: Allow reading # as a digit [https://gerrit.asterisk.org/c/asterisk/+/16424|https://gerrit.asterisk.org/c/asterisk/+/16424] By: Friendly Automation (friendly-automation) 2021-09-01 10:31:00.679-0500 Change 16425 merged by George Joseph: app_read: Allow reading # as a digit [https://gerrit.asterisk.org/c/asterisk/+/16425|https://gerrit.asterisk.org/c/asterisk/+/16425] By: Friendly Automation (friendly-automation) 2021-09-01 10:31:09.714-0500 Change 16426 merged by George Joseph: app_read: Allow reading # as a digit [https://gerrit.asterisk.org/c/asterisk/+/16426|https://gerrit.asterisk.org/c/asterisk/+/16426] By: Friendly Automation (friendly-automation) 2021-09-01 10:31:18.805-0500 Change 16352 merged by George Joseph: app_read: Allow reading # as a digit [https://gerrit.asterisk.org/c/asterisk/+/16352|https://gerrit.asterisk.org/c/asterisk/+/16352]