Summary:	ASTERISK-18565: Voicemail saycid: Play Callers name for external callers if available.
Reporter:	Russell Brown (ruffle)	Labels:
Date Opened:	2011-09-16 03:27:55	Date Closed:	2011-12-16 16:08:40.000-0600
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Applications/app_voicemail/NewFeature
Versions:	1.4.42 1.8.6.0 10.0.0-beta2	Frequency of Occurrence
Related Issues:
Environment:	All AFAIK.	Attachments:	( 0) r ( 1) _unified_diff_ASTERISK-18565.diff
Description:	If saycid is set (Say the Caller id information before the message) and a recording file matching the callerid number exists in VM_SPOOL_DIR/Callerids then play that instead of reading out the whole number. app_voicemail still reads the number when playing the message envelope or doing a ringback. Messages left from internal contexts are not effected (they already read out the name from the users voicemail if found so this mod adds this behavior for external callers). Why?  Well, when dealing with hundreds of voicemail messages (customers leaving orders overnight) it's much easier for a human to process if a short audible name is presented (...called from Mrs Miggins Pie Shoppe) rather than listening to the telephone number digit by digit (...called from 01234567890). If there are no recordings matching the callerid then the number is read out digit by digit as before. This has been developed against 1.4.4X but applies to 1.8 and 1.10 as the relevant parts of app_voicemail.c are the same.
Comments:	By: Jonathan Rose (jrose) 2011-12-09 12:32:23.130-0600 You'll need to resubmit your patch in a universal diff format.  Also, please, if it's at all possible make the patch against 1.8. In order to make a universal diff, you can do a fresh checkout of Asterisk from svn and apply your patch and when you are ready to make the diff use the 'svn diff' command or you can instead use diff's "-u" option. By: Jonathan Rose (jrose) 2011-12-16 10:35:26.969-0600 conversion of r to be a unified diff working with 1.8