| Summary: | ASTERISK-18643: [patch] Allow sip devices to have externaddr setting | ||
| Reporter: | Olle Johansson (oej) | Labels: | patch |
| Date Opened: | 2011-09-29 07:12:44 | Date Closed: | |
| Priority: | Minor | Regression? | No |
| Status: | Open/New | Components: | Channels/chan_sip/NewFeature |
| Versions: | SVN 13.18.4 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) chan_sip.c_extrernaddr_1.6.2.diff ( 1) chan_sip-peer_externaddr_1.8.32.2.patch ( 2) sip_externaddr_trunk.diff | |
| Description: | This patch adds the ability to specify externaddr= on a per device basis in sip.conf. | ||
| Comments: | By: Grigoriy Puzankin (boroda) 2012-11-23 07:55:14.608-0600 Are there any plans on completing this feature? By: Olle Johansson (oej) 2012-11-26 02:50:33.736-0600 Yes, but priorities depend on funding. Have you tested the patch, does it work for you? By: Joze Zivic (jozza) 2013-01-20 19:09:57.206-0600 I have rewritten my own patch for 1.6 based on this patch and found that it is incomplete. It doesn't cover all scenarios at all. Many sip messages pass through without having externip changed according to peer. These include: register, sdp in responses and others... I am pretty certain that the case is the same in 1.8+ The proper solution for this is more complex than it looks, so i don't have any yet. Fortunately i need this feature as well, so i'll try to make a proper patch that will cover all scenarios. By: Joze Zivic (jozza) 2013-01-31 08:43:23.826-0600 I fixed the sip externaddr feature for 1.6.2.24 (That's the one i use). Short test confirms, but it is not tested nearly enough. It was quite simple actually. Besides the new settings added to support externaddr, it only took 2 lines of code in ast_sip_ouraddrfor function to fix this issue. I didn't create a patch (i'm not into patches), but i am attaching the complete chan_sip.c, in case anyone is interested or want to create a patch for 1.8+. I believe it is working properly now. I'll continue to watch this thread for news on patches. By: Joze Zivic (jozza) 2013-02-02 08:21:18.078-0600 I made a patch for 1.6.2 I'll also make one for 11, so it can be added to trunk and eventually released By: Joze Zivic (jozza) 2013-02-02 11:15:28.625-0600 patch for trunk is untested By: Olle Johansson (oej) 2013-04-29 14:10:51.769-0500 THanks for your contribution and tests. My patch has been working in the scenario I created it for almost for two years - plain SIP trunking. I propably missed the registrations and subscriptions, since they where out of scope. Will look into this soon. By: Joze Zivic (jozza) 2015-03-08 12:12:45.109-0500 A patch for 1.8.32.2 | ||