[Home]

Summary:ASTERISK-18995: Support for OGG/Speex file format
Reporter:Timo Teräs (fabled)Labels:
Date Opened:2011-12-08 08:24:23.000-0600Date Closed:2016-09-23 14:43:48
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Formats/NewFeature
Versions:10.0.0-rc2 Frequency of
Occurrence
Related
Issues:
cannot be resolved before merging ofASTERISK-18994 playback of file format without seeking is broken
Environment:Attachments:( 0) format_ogg_speex.c
( 1) format_ogg_speex.c
( 2) format_ogg_speex.c
Description:Support OGG/Speex format to avoid encoding overhead when speex is used and we have the proper files available.
Comments:By: Timo Teräs (fabled) 2011-12-08 08:25:55.806-0600

The hack in the ogg_speex_seek() can be removed once ASTERISK-18994 is fixed.

By: Timo Teräs (fabled) 2011-12-21 02:15:32.858-0600

Version 2.

By: Timo Teräs (fabled) 2011-12-21 02:16:45.342-0600

I update the seeking code to remove unnecessary cruft. The locking to OGG stream serialno is also now slightly improved. It finds the first stream with valid Speex and sticks with it. It does not change streams after that.

By: Timo Teräs (fabled) 2014-10-31 02:45:48.301-0500

Updated for asterisk 13.

By: Matt Jordan (mjordan) 2015-03-13 21:55:18.379-0500

Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review [1] instructions on the wiki. Be sure to:
* Verify that your patch conforms to the Coding Guidelines [2]
* Review the Code Review Checklist [3] for common items reviewers will look for
* If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch [4]

When ready, submit your patch and any tests to Review Board [5] for code review.

Thanks!

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review
[2] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines
[3] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist
[4] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
[5] https://wiki.asterisk.org/wiki/display/AST/Review+Board+Usage