| Summary: | ASTERISK-19298: segmentation fault in chan_ooh323 | ||
| Reporter: | robinfood (robinfood) | Labels: | |
| Date Opened: | 2012-02-03 09:59:08.000-0600 | Date Closed: | 2012-02-14 03:50:19.000-0600 |
| Priority: | Critical | Regression? | |
| Status: | Closed/Complete | Components: | Addons/chan_ooh323 |
| Versions: | 1.8.9.0 | Frequency of Occurrence | One Time |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) issue19298.patch | |
| Description: | I've encountered a segmentation fault in chan_ooh323.c, line 452-453: manager_event(EVENT_FLAG_SYSTEM, "ChannelUpdate", "Channel: %s\r\nChanneltype: %s\r\n" "CallRef: %d\r\n", ch->name, "OOH323", i->call_reference); After looking in the code, I've found very close NULL assignment: there is ch=NULL; in the line 448. Please fix it. | ||
| Comments: | By: Alexander Anikin (may213) 2012-02-04 09:58:23.454-0600 This could be happen in some situations. Will produce patch that fix this issue. By: Alexander Anikin (may213) 2012-02-07 14:49:07.802-0600 Patch is attached. Please test. Manager_event is now called only if there is not null channel structure. By: robinfood (robinfood) 2012-02-12 11:08:47.413-0600 Thank you for the fix - it looks fine for me, and there was no segmentation faults during last four days. By: robinfood (robinfood) 2012-03-06 06:33:42.789-0600 Is it possible to merge this patch with asterisk branches? Bug was reported for version 1.8.9.0, but now it still exists in 1.8.10.0. By: Alexander Anikin (may213) 2012-03-06 14:43:12.600-0600 I suggest that 1.8.10.0 was released before patch commited to svn. It will included in next release of 1.8 You can apply this patch to 1.8.x which you use, patch is very simple and must be ok for any 1.8 version. | ||