Summary:	ASTERISK-19516: [patch] Enable RFC 4662/Broadsoft Resource list subscriptions in Asterisk 1.8.9.0
Reporter:	Dennis Trubitski (deniq)	Labels:
Date Opened:	2012-03-12 07:29:32	Date Closed:	2017-07-25 16:48:54
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Subscriptions
Versions:	1.8.9.0 1.8.20.1	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_sip.patch ( 1) chan_sip.patch ( 2) rlist.patch ( 3) rlist-1.8.20.1.patch ( 4) sip_h.patch ( 5) sip_h.patch
Description:	I've modified and ported Dvossel's code to the current version of Asterisk to allow resource list subscriptions be properly processed. I've kept Dvossel's concept of keeping resource lists in sip.conf as type=resourcelist
Comments:	By: Dennis Trubitski (deniq) 2012-03-12 07:50:32.445-0500 Patches are made against release version 1.8.9.0 By: Matt Jordan (mjordan) 2012-03-12 08:39:13.917-0500 Hi Dennis - Once the license agreement is signed, please post the patches to ReviewBoard for review by the developer community: https://reviewboard.asterisk.org/ If you need an account on ReviewBoard, e-mail me at mjordan@digium.com and I'll set one up for you. Thanks! Matt By: Dennis Trubitski (deniq) 2012-03-12 13:18:31.799-0500 I've emailed a request for a reviewboard account By: Matt Jordan (mjordan) 2012-03-13 10:44:30.231-0500 And I've created one for you.  Please don't forget to sign a license agreement - without that, the patches will not be able to be reviewed or committed to Asterisk.  Thanks! By: Dennis Trubitski (deniq) 2012-03-13 13:55:59.432-0500 against release version 1.8.9.0 By: Dennis Trubitski (deniq) 2012-03-13 13:57:20.973-0500 against release version 1.8.9.0 By: Igor Drach (laigor) 2012-03-22 17:31:53.237-0500 I test this patch with asterisk 1.8.9.3 and phone Panasonic KX-UT133. This patch is the only way to get BLF working on this phone. Work perfectly!!! By: Matt Jordan (mjordan) 2012-03-23 10:18:40.893-0500 The next step in this process would be to put the patches up for review on reviewboard.  I missed this when I initially looked at this issue, but new features have to be developed against SVN trunk, not 1.8. By: Dennis Trubitski (deniq) 2012-04-02 11:36:41.749-0500 Yes, I realized that. I think I will have more time in next 2 weeks and will test it against the trunk... By: Igor Drach (laigor) 2012-04-02 13:14:32.642-0500 Updated for asterisk 1.8.11.0 By: Robert Cox (robertmcox) 2012-04-08 20:59:16.339-0500 Dennis -- I tested your patch against both 1.8.9.3 and 1.8.11.0 and it does indeed provide support for the BLF function of the Panasonic KX-UT136 phones I have.   The patch however appears to break the existing in-built BLF function of Asterisk, at least for the Grandstream devices GXP-2010 and GXP-2110 I have at my disposal.  I did attempt to configure the Grandstream devices to support the resource list, but was unsuccessful. I would also note that having to add "monitor = xx" for each extension in sip.conf is a bit painful and I would rather see all hints in the "context = somecontext" automatically populated. I am  not (much of) a coder and my time is limited, so I have not reviewed your patch to see how/where it breaks the in-built Asterisk BLF functionality, but my vote is that this patch is a no-go until it has been proven to not affect existing functionality. Being interested in making the Panasonic devices present BLFs properly, I am able/willing to test/troubleshoot with you on a limited basis. By: Paul Larsen (plars3n) 2012-05-26 17:11:40.238-0500 I would like to help test the patch. I'm a Panasonic telephone dealer and have already sold KX-UTs with FreePBX Asterisk. It was only then I discovered the BLF issue. I'm very anxious to get this resolved as my customers are going nuts without any lights. Just let me know how I can help. By: Richard La China (motorichard) 2012-05-29 18:00:49.907-0500 Is this patch available now?  We've got a couple kx-ut133s that need the blf working.  Thank you. By: Paul Larsen (plars3n) 2012-06-04 22:24:26.992-0500 I installed the patched version of 1.8.9.3 today. BLFs on 4 KX-UT136s are working, two local and two remote extensions. By: Dennis Trubitski (deniq) 2012-06-05 08:33:21.412-0500 I have this working in few 1.8.9.0 installations for last 3 months without any problems. Phones are LG LIP-6830D. The only issue is when the phone reboots and it has more than 16 BLF buttons configured, BLFs higher than 16 (aka 17-24) are not initially synchronized (full notify dialog). They are properly synchronized later with partial notify. This could be a phone issue (LIP-6830D) - limitation of the sip message size. Could you please verify that you have no issues with Panasonic phones with BLF buttons 17+? By: Dennis Trubitski (deniq) 2012-06-05 08:49:30.015-0500 As per Robert Cox's comment - GXPs and other phones (Snom,Linksys etc) that support Dialog Notify for BLF management have to be configured to use Broadsoft BLF if they coexist with other phones that use this patch. By: Richard La China (motorichard) 2012-06-25 11:42:02.143-0500 Dennis or Paul / can you please tell me how I install the patch?  Also, will this patch adversely effect other brand phones (aastra) on the same Asterisk box? Thank you! Richard By: Dirk Augustusburg (augustusburg) 2012-08-13 01:53:14.624-0500 Can I apply the Patch on Version 1.8.13.0? By: Dennis Trubitski (deniq) 2012-09-03 10:48:22.549-0500 This is the patch in proper format for SVN Revision 372129 (1.8.15.1 I believe). You can use a standard patch -p0 < rlist.patch to apply By: Dirk Augustusburg (augustusburg) 2012-09-03 14:15:18.067-0500 Thanks! By: Dennis Trubitski (deniq) 2013-02-21 22:16:24.860-0600 Stand by for the new version which fixes following issues: Supports Asterisk 1.8.20 Allows the other phones like Grandstream ,Snom, etc. that use dialog-xml subscriptions to coexist with phones that use resorce list (rlmi) subscriptions. There is a new sip variable called rlist_useragent which can be set to a portion or whole user-agent string of the phone. For example, if you want to rlmi-xml subscriptions for Panasonic phones only, you need to set rlist_useragent=panasonic or rlist_useragent=pana. By default if the rlist_useragent is not set, resource list subscriptions are applicable to all type of phones. Also, I've discovered some issues when using FreePbx as the front end. For FreePbx version 2.8 or lower you have to put [rlist_name] section in sip_custom_post.conf. For version 2.10 it has to be in sip_custom.conf. Just a reminder, the format of resource list declaration is as follows: [rlist_name] type=resourcelist monitor=100 monitor=101 ... monitor=120 By: Dennis Trubitski (deniq) 2013-03-03 22:04:02.574-0600 The patch is ready (built version 1.8.20.1). Let me know if you have any issues or suggestions. By: Franc Muñoz (ZeroWorks) 2013-09-12 14:18:45.734-0500 Does anybody tested on 1.8.23.0? By: Franc Muñoz (ZeroWorks) 2013-09-17 00:15:41.462-0500 Can't make it work on 1.8.20.1 could anybody provide an example for sip.conf and extensions.conf please? I'm using Panasonic KX-UT248. Thank you in advance! By: Heiner Repsol (Netboi) 2014-03-07 05:58:36.373-0600 Tested last Patch (rlist-1.8.20.1.patch) on 1.8.20.1 - Patched and compiled without errors. But: BLF not functioning (maybe its my fault). (http://www.voip-info.org/wiki/view/panasonic+kx-ut13x+BLF+in+asterisk) So i want to check my config with your (proven) patch against 1.8.9.0. But patching with "rlist.patch" above gives errors and chan_sip.c does not compile? (chan_sip.c: Hunk #16 FAILED at 25405 - sip.h: Hunk #2 FAILED at 1077) Used "sudo patch -p0 < rlist.patch" in "~/asterisk-1.8.9.0" Edit: Your old Patch (rlist.patch) runs agains 1.8.11.0 without errors. OK By: Rusty Newton (rnewton) 2017-07-25 16:48:54.296-0500 Closing this out since there has been no movement since 2014 and it was filed against a now EOL version of Asterisk. With no core development on chan_sip now, this patch is unlikely to get merged in. If the patch is compatible with a currently supported version please request to reopen the issue and update it to reflect that information. At that point a community developer is welcome to walk the patch through the review process at any time.