Summary:	ASTERISK-19577: Overcoming 64 callgroup / pickupgroup limit by creating "group contexts"
Reporter:	Alex (alexat)	Labels:
Date Opened:	2012-03-23 04:00:08	Date Closed:	2015-02-26 09:17:44.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:	1.8.10.0	Frequency of Occurrence
Related Issues:
Environment:	Any	Attachments:	( 0) asterisk_caller_group_context_trunk.patch
Description:	Supplied patch allows to overcome 64 callgroup / pickup group limit by adding "groupcontext" parameter to peers and channels. Each group context (int ID) from the user point of view is a virtual independent set of 64 call/pickup groups. From the developer's perspective, this is just an integer that gets compared along with group mask. Result is: call pickup is now determined not only by group mask, but also by the "group context" ID. Pickups between group contexts are impossible. It's suitable for large installations, where each client requires its own pickup group. The patch was made to be as inobtrusive as possible, just extending existing functionality. The one and only known limitation is with mISDN channels (mISDN is modded in the patch to always use the default group context 0, because group configuration here is integrated with the binary structure I did not want to change). Maybe someone more knowledgeable with the mISDN module can improve that.
Comments:	By: Alex (alexat) 2012-03-23 04:02:36.630-0500 Asterisk 1.8.10.0 "group contexts" patch. May be used for any purpose, copied and redistributed even without any author permission. By: Matt Jordan (mjordan) 2012-03-26 07:56:45.281-0500 Your patch needs to be re-uploaded after signing a valid license agreement.  Simply commenting in the issue what your level of agreement is isn't sufficient.  I've removed the patch for now - please reupload it with the correct options and after signing a license agreement. By: Alex (alexat) 2012-03-26 22:35:43.949-0500 Re-uploaded patch By: Alex (alexat) 2012-03-28 22:35:51.569-0500 Have some problems signing license. Got no acknowledgement by email, and patch changed from "license pending" to "no license". Is this normal? By: Matt Jordan (mjordan) 2012-04-02 09:41:04.789-0500 Nope, that's not normal.  I'm not sure why it went to no license - do you mind trying again? Also: please note that the patch, since it is new behavior, will have to be written against trunk. By: Alex (alexat) 2012-04-02 13:46:49.304-0500 Okay. I will redo it against trunk and repost as soon as it is complete. It will take a few days (too busy @ work now) but must be complete this week. By: Alex (alexat) 2012-04-09 08:48:22.548-0500 Have problem uploading patch against trunk. Something is up with the license stuff. Have signed online agreement about 2 weeks ago. No email was got from the system regarding it in 2 weeks, Now it mentions my license agreement is outdated or invalid and does not allow to upload. Signed it again, but it mentions some confirmation email before I can upload. Hope everything will go well. By: Alex (alexat) 2012-04-09 09:01:06.432-0500 Uploading patch against trunk. By: Matt Jordan (mjordan) 2015-02-26 09:17:37.385-0600 I know this issue has been open for awhile, and the improvement hasn't been applied. I'm sorry we didn't get to it - since this issue was opened, we've made it easier to get code reviewed/included by letting anyone who has a contributor license agreement push the patch up to review board. While that doesn't help this issue, hopefully any contributions made in the future will get reviewed/included faster. Unfortunately, a different approach was taken in Asterisk 11 to this patch by allowing the use of named callgroups/pickupgroups, which essentially gives an unlimited number of groups that can be created. Since an alternative approach ended up being used, I'm going to close this issue out as Won't Fix.