[Home]

Summary:ASTERISK-19755: __ao2_ref() validates user_data twice
Reporter:Guenther Kelleter (gkelleter)Labels:
Date Opened:2012-04-19 06:58:17Date Closed:2012-05-01 18:12:19
Priority:MinorRegression?
Status:Closed/CompleteComponents:Core/General
Versions:1.8.9.3 1.8.10.1 1.8.11.0 1.8.12.0 1.8.13.0 10.3.0 10.4.0 10.5.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ao2_ref.patch
Description:__ao2_ref() calls INTERNAL_OBJ(user_data) and checks result for NULL. Then it calls internal_ao2_ref() which does exactly the same again.

The first check in __ao2_ref() can be omitted.
Comments:By: Guenther Kelleter (gkelleter) 2012-04-19 06:59:17.618-0500

Patch attached for 1.8.9.3