[Home]

Summary:ASTERISK-19859: cid_tag is not set according to the sip configuration anymore if get_rpid() != 0
Reporter:Thomas Arimont (tomaso)Labels:
Date Opened:2012-05-11 07:19:48Date Closed:2012-06-12 10:42:20
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:1.8.9.3 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Attachments:
Description:Due to changes in chan_sip.c 'some time' before, the cid_tag is not set according to the sip configuration anymore if the result of get_rpid() != 0:

{noformat}
static enum check_auth_result check_peer_ok(..)
{
...
               if (!get_rpid(p, req)) {
                       ...
if (!ast_strlen_zero(peer->cid_tag))  /* delete this here */
ast_string_field_set(p, cid_tag, peer->cid_tag); /* delete this here */
                       ...
          }
               /* and insert it here instead (or do the cid_tag setting in get_rpid())
if (!ast_strlen_zero(peer->cid_tag))
ast_string_field_set(p, cid_tag, peer->cid_tag);
               */

...
}
{noformat}
Comments: