| Summary: | ASTERISK-20125: patch for alloca and ast_strdupa checked for return values | ||
| Reporter: | Walter Doekes (wdoekes) | Labels: | |
| Date Opened: | 2012-07-12 08:40:27 | Date Closed: | 2012-08-14 10:27:13 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | |
| Versions: | 1.8.14.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) issueA20125_alloca_no_check_return.patch ( 1) issueA20125_alloca_no_check_return2.patch ( 2) issueA20125_alloca_no_check_return3.patch | |
| Description: | In several places alloca and/or ast_strdupa get checked for their return value. They won't return NULL, and if alloca did, then ast_strdupa would segfault anyway. Attached, the immediately obvious ones from chan_sip.c | ||
| Comments: | By: Rusty Newton (rnewton) 2012-07-17 17:45:19.847-0500 Thanks Walter! Extra points if the issue exists in trunk and you patch that too. :) By: Walter Doekes (wdoekes) 2012-08-14 03:21:48.984-0500 Somehow this didn't get closed. Because it is in feedback state? Would've been nice to see my name in the commit msg though.. By: Kinsey Moore (kmoore) 2012-08-14 10:26:26.575-0500 Sorry, it's fixed now. I thought I included that. | ||