Summary: | ASTERISK-20211: chan_sip incorrect mapping from sip error codes to internal (ISDN) CAUSECODEs. | ||
Reporter: | Jaco Kroon (jkroon) | Labels: | |
Date Opened: | 2012-08-10 05:29:49 | Date Closed: | 2012-08-16 14:51:34 |
Priority: | Major | Regression? | Yes |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | 1.8.13.1 | Frequency of Occurrence | Constant |
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk_sip_causes.patch ( 1) asterisk_sip_causes.patch | |
Description: | When initiating a call via Dial(SIP/xyz) and the destination channel hangs up the CAUSECODE will always be 34, even when upstream for example sends us a 404 (NOTFOUND) which obviously maps better to CAUSECODE=1. Fortunately there already exists a function that can perform this mapping, so we just need to use it when receiving error codes from upstream instead of always hanging up with causecode 34. | ||
Comments: | By: Jaco Kroon (jkroon) 2012-08-10 05:32:28.832-0500 Apply with -p1. By: Jaco Kroon (jkroon) 2012-08-10 05:40:53.275-0500 This fixes the mapping to be correct. By: Walter Doekes (wdoekes) 2012-08-16 08:03:09.918-0500 Wasn't this fixed by this in 1.8? {noformat} $ svn log -r 368498 ------------------------------------------------------------------------ r368498 | mmichelson | 2012-06-04 23:56:05 +0200 (Mon, 04 Jun 2012) | 14 lines Relay proper SIP responses on calling side. Revision 351130 broke corect HANGUPCAUSE setting for the 404 case in chan_sip. Other cases were also potentially broken. This patch fixes the relaying of causes to be what they used to be. (closes issue ASTERISK-19914) Reported by Pavel Troller Tested by Walter Doekes (via a reviewboard test to be committed later) Patches: chan_sip.diff uploaded by Pavel Troller (license #6302) ------------------------------------------------------------------------ {noformat} By: Jaco Kroon (jkroon) 2012-08-16 09:49:32.437-0500 Does indeed look like this is already sorted in 1.8.15.0 so I guess you can close. |