| Summary: | ASTERISK-20224: Fix Documentation | ||
| Reporter: | Pedro Kiefer (pedrokiefer) | Labels: | |
| Date Opened: | 2012-08-13 12:47:17 | Date Closed: | 2012-09-05 11:04:08 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | Applications/app_alarmreceiver |
| Versions: | SVN | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 0007-Fix-documentation.patch | |
| Description: | Fix Documentation strings, the application was not using doxygen | ||
| Comments: | By: Pedro Kiefer (pedrokiefer) 2012-08-13 12:47:48.108-0500 Update doc strings By: Andrew Latham (lathama) 2012-08-19 14:30:39.753-0500 I just attempted to test this. Can you upload a clean "svn diff" from trunk? patch app_alarmreceiver.c < ../0007-Fix-documentation.patch patching file app_alarmreceiver.c Hunk #1 FAILED at 105. Hunk #2 succeeded at 143 with fuzz 1 (offset 3 lines). Hunk #3 succeeded at 169 with fuzz 1 (offset 4 lines). Hunk #4 succeeded at 233 with fuzz 1 (offset 7 lines). Hunk #5 FAILED at 297. Hunk #6 FAILED at 342. Hunk #7 FAILED at 352. Hunk #8 FAILED at 400. Hunk #9 succeeded at 430 with fuzz 1 (offset -5 lines). Hunk #10 succeeded at 585 (offset 7 lines). Hunk #11 succeeded at 661 (offset 7 lines). Hunk #12 succeeded at 735 (offset 3 lines). 5 out of 12 hunks FAILED -- saving rejects to file app_alarmreceiver.c.rej By: Pedro Kiefer (pedrokiefer) 2012-08-20 08:46:40.095-0500 Andrew, This patch was made on top of a few others, which basically clean up this App. Please, take a look on https://reviewboard.asterisk.org/r/2075/ By: Andrew Latham (lathama) 2012-08-20 11:11:58.876-0500 Ok, I missed that review-board relation. | ||