Summary: | ASTERISK-20289: [patch] Use ALAW in app_alarmreceiver | ||
Reporter: | Kaloyan Kovachev (knk) | Labels: | |
Date Opened: | 2012-08-21 07:14:44 | Date Closed: | 2012-10-17 14:05:33 |
Priority: | Minor | Regression? | |
Status: | Closed/Complete | Components: | Applications/app_alarmreceiver |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) alaw.diff | |
Description: | In Europe ALAW is used and switching the read/write formats to ULAW causes problems. Do not force ULAW if the call is in ALAW or ULAW allready. | ||
Comments: | By: Kaloyan Kovachev (knk) 2012-08-21 07:17:30.814-0500 Should be applied after the patch from review 2075 which is removing the proprietary tone burst generation. [edit by Rusty Newton - here is a link to https://reviewboard.asterisk.org/r/2075/] By: Kaloyan Kovachev (knk) 2012-10-17 03:39:46.267-0500 https://reviewboard.asterisk.org/r/2075 is already in trunk and this patch can now be applied. Should i open a review? By: Pedro Kiefer (pedrokiefer) 2012-10-17 07:21:17.966-0500 Kaloyan, No, there is no need for a review on this patch, as I'm testing https://reviewboard.asterisk.org/r/2088/ which already includes this. I intend to merge it ASAP, as it adds some really nice features. By: Kaloyan Kovachev (knk) 2012-10-17 08:21:27.717-0500 2088 is missing part of the ASTERISK-20484 fixes: {noformat} @@ -465,7 +466,7 @@ res = send_tone_burst(chan, "1400", 100, tldn, 0); if (!res) { ast_verb(4, "AlarmReceiver: Sending 2300Hz 100ms burst (ACK)\n"); - res = send_tone_burst(chan, "2300", 100, tldn, 0); + res = send_tone_burst(chan, "2300", 100, tldn, 100); } } if (res) { {noformat} I will update it in few minutes By: Pedro Kiefer (pedrokiefer) 2012-10-17 14:05:33.859-0500 Merged https://reviewboard.asterisk.org/r/2088/ which includes this patch. |