[Home]

Summary:ASTERISK-20325: Comments in configs/func_odbc.conf.sample are not consistent with examples. Missing examples.
Reporter:Olivier Krief (okrief)Labels:
Date Opened:2012-08-27 09:04:01Date Closed:2020-03-17 08:19:53
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Functions/func_odbc
Versions:1.8.12.2 13.18.4 Frequency of
Occurrence
Related
Issues:
Environment:Debian SqueezeAttachments:
Description:File configs/func_odbc.conf.sample contains several comments and examples.
To me, both are not always consistent and some comments are missing.

For instance, in comments block, option readhandle is listed and option dsn is not.
In provided examples, option dsn is displayed and option readhandle is not.
Maybe a comment block explaining dsn option should be added.
Maybe an example using readhandle option should be included.


In ANTIGF example, syntax option is shown.
Maybe, this option should be added the comments block above.

(To be honest, I checked this with asterisk version 1.8.12.0.
I think this is still valid for current 1.8 and 10).
Comments:By: Matt Jordan (mjordan) 2012-09-07 11:44:58.142-0500

There is a much greater chance of this being worked if you provide a patch with the wording/examples that you believe should be there.

By: Friendly Automation (friendly-automation) 2020-03-17 08:19:55.855-0500

Change 13969 merged by George Joseph:
func_odbc.conf.sample: Clarify sample documentation

[https://gerrit.asterisk.org/c/asterisk/+/13969|https://gerrit.asterisk.org/c/asterisk/+/13969]

By: Friendly Automation (friendly-automation) 2020-03-17 08:20:08.612-0500

Change 13943 merged by George Joseph:
func_odbc.conf.sample: Clarify sample documentation

[https://gerrit.asterisk.org/c/asterisk/+/13943|https://gerrit.asterisk.org/c/asterisk/+/13943]

By: Friendly Automation (friendly-automation) 2020-03-17 08:20:24.377-0500

Change 13967 merged by George Joseph:
func_odbc.conf.sample: Clarify sample documentation

[https://gerrit.asterisk.org/c/asterisk/+/13967|https://gerrit.asterisk.org/c/asterisk/+/13967]

By: Friendly Automation (friendly-automation) 2020-03-17 08:20:37.571-0500

Change 13968 merged by George Joseph:
func_odbc.conf.sample: Clarify sample documentation

[https://gerrit.asterisk.org/c/asterisk/+/13968|https://gerrit.asterisk.org/c/asterisk/+/13968]