| Summary: | ASTERISK-20355: [patch] Provide an entry point for stdexten written in AEL from pbx_config.c | ||||||
| Reporter: | Octavio Ruiz (tacvbo) | Labels: | AEL AELSub Gosub Macro asterisk patch | ||||
| Date Opened: | 2012-09-03 22:23:12 | Date Closed: | 2018-07-11 04:40:57 | ||||
| Priority: | Minor | Regression? | No | ||||
| Status: | Closed/Complete | Components: | Core/Configuration PBX/pbx_ael PBX/pbx_config | ||||
| Versions: | SVN 11.0.0-beta1 13.18.4 | Frequency of Occurrence | |||||
| Related Issues: |
| ||||||
| Environment: | Centos 5, Centos 6 | Attachments: | ( 0) aelsub-stdexten.patch | ||||
| Description: | ASTERISK-18809 and ASTERISK-19457 changed the way pbx_config.c invokes the stdexten subroutine from Macro to Gosub, providing examples at extensions.conf and without a means of backwards compatibility. Since this change, any stdexten written in AEL would be not reachable by the Gosub application when configuring pbx_config.so to do so due the new approach of how stdexten through Gosub is called (explained in extensions.conf.sample). Being not able to define arbitrary priorities in AEL there is no way to re implement stdexten in this language having to fall back to Macro application loosing the benefit of better nesting and the Gosub use trend. | ||||||
| Comments: | By: Octavio Ruiz (tacvbo) 2012-09-03 22:25:43.405-0500 This improvement adds a stdexten option at asterisk.conf for calling the AELSub application in order to provide a stable entry point into AEL written stdexten subroutine. {noformat};stdexten = gosub ; How to invoke the extensions.conf stdexten. ; macro - Invoke the stdexten using a macro as ; done by legacy Asterisk versions. ; aelsub - Invoke the stdexten sutbroutine using AELSub ; when stdexten is defined in AEL. ; gosub - Invoke the stdexten using a gosub as ; documented in extensions.conf.sample. {noformat} By: Octavio Ruiz (tacvbo) 2012-09-06 15:48:41.072-0500 I think comments in ASTERISK-17497 are relevant to this. By: Corey Farrell (coreyfarrell) 2017-12-15 10:03:07.235-0600 Are you interested in pursuing this further? If so the patch will need to be rebased so it can apply the the current {{master}} branch and it will need to go through code review. ---- Thanks for the contribution! If you'd like your contribution to be included faster, you should submit your patch for code review by the Asterisk Developer Community. To do so, please follow the Code Review \[1\] instructions on the wiki. Be sure to: * Verify that your patch conforms to the Coding Guidelines \[2\] * Review the Code Review Checklist \[3\] for common items reviewers will look for * If necessary, provide tests for the Asterisk Test Suite that verify the correctness of your patch \[4\] When ready, submit your patch and any tests to Gerrit \[5\] for code review. Thanks! \[1\] https://wiki.asterisk.org/wiki/display/AST/Code+Review \[2\] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines \[3\] https://wiki.asterisk.org/wiki/display/AST/Code+Review+Checklist \[4\] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation \[5\] https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage By: Octavio Ruiz (tacvbo) 2017-12-16 16:36:48.756-0600 Yes, I'm interested in pursuing this further. I will update the patch according current guidelines and current master. By: Joshua C. Colp (jcolp) 2017-12-20 06:36:30.538-0600 Assigning back to you and putting into feedback as you plan to update things. By: Joshua C. Colp (jcolp) 2018-07-11 04:40:57.507-0500 Suspended due to lack of activity. This issue will be automatically re-opened if the reporter posts a comment. If you are not the reporter and would like this re-opened please create a new issue instead. If the new issue is related to this one a link will be created during the triage process. Further information on issue tracker usage can be found in the Asterisk Issue Guidlines [1]. [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines | ||||||