[Home]

Summary:ASTERISK-20380: Bad ao2_unlock call in app_queue's try_calling
Reporter:Jeremy Pepper (jpepper)Labels:
Date Opened:2012-09-06 20:51:18Date Closed:2012-09-07 16:58:07
Priority:MinorRegression?
Status:Closed/CompleteComponents:Applications/app_queue
Versions:11.0.0-beta1 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) fix-local-channel-locking.patch
Description:It looks like there's a typo in try_calling:

{code}
if (!(dialed_interfaces = ast_calloc(1, sizeof(*dialed_interfaces)))) {
callattempt_free(tmp);
ao2_ref(cur, -1);
ao2_iterator_destroy(&memi);
ao2_unlock(&qe->parent);
goto out;
}
{code}

Surely that should be spelled {{ao2_unlock(qe->parent);}}.
Comments:By: Matt Jordan (mjordan) 2012-09-07 08:36:31.359-0500

Pretty sure this is going to be the case in 1.8 and 10 as well.