[Home]

Summary:ASTERISK-20505: Migrate hashtest/hashtest2 to be unit tests
Reporter:Matt Jordan (mjordan)Labels:
Date Opened:2012-10-02 15:41:35Date Closed:2012-11-15 16:32:45.000-0600
Priority:MajorRegression?
Status:Closed/CompleteComponents:Utilities/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:After making some innocuous changes in {{astobj2}}, Richard informed me that I broke the build.

What?  How could this be?  I compiled with {{--enable-dev-mode} and everything!

As it turns out, {{hasthtest}} and its slightly more evil cousin, {{hashtest2}}, still lurk in utilities.  Because they are stand-alone applications, anything that they reference that in turn uses something in asterisk that they do not link with has to be declared in their translation units.  Otherwise... no linky.

When I added the call to {{ast_register_atexit}} into {{astobj2}}, this broke their build - and they aren't built by default.

What's worse is that these are really unit tests for core data structures in Asterisk that - despite our best wishes - are still used extensively in important locations in Asterisk.  And they are not executed as part of our continuous integration.  Not good.

This task is to take the meat of those two applications and turn them into sustainable, executable unit tests.
Comments: