[Home]

Summary:ASTERISK-20533: Odd happenings in inotify and kqueue code with spool files.
Reporter:Richard Mudgett (rmudgett)Labels:
Date Opened:2012-10-08 16:53:24Date Closed:
Priority:MinorRegression?No
Status:Open/NewComponents:PBX/pbx_spool
Versions:1.8.18.0 13.18.4 Frequency of
Occurrence		Frequent
Related
Issues:
Environment:Attachments:
Description:While working on ASTERISK-17231 I came across some odd behavior.  When INOTIFY and KQUEUE support was added, a warning message was conditionaled out.  I added the todo comment to indicate that something strange is going on.  Further investigation is needed to determine if there is a better way to do this since call files may be processed erroneously.

{code:title=pbx/pbx_spool.c}
/* Attempt to open the file */
f = fopen(o->fn, "r");
if (!f) {
#if defined(HAVE_INOTIFY) || defined(HAVE_KQUEUE)
/*!
* \todo XXX There is some odd delayed duplicate servicing of
* call files going on.  We need to suppress the error message
* if the file does not exist as a result.
*/
if (errno != ENOENT)
#endif
{
ast_log(LOG_WARNING, "Unable to open %s: '%s'(%d), deleting\n",
o->fn, strerror(errno), (int) errno);
}
remove_from_queue(o, "Failed");
free_outgoing(o);
return -1;
}
{code}
Comments: