| Summary: | ASTERISK-20628: [patch] - main/pbx.c - ShowDialPlan generates with error if no Exten: was presented and there are no exten => lines present | ||
| Reporter: | Jaco Kroon (jkroon) | Labels: | |
| Date Opened: | 2012-10-30 08:48:55 | Date Closed: | 2012-11-12 14:47:38.000-0600 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | PBX/General |
| Versions: | 1.8.15.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-showdialplan-incorrect-error.patch | |
| Description: | When I request a:
Action: ShowDialplan Context: hints and hints is defined as: [hints] include => foo include => bar Then the list will contain the ListDialplan entries for the two includes, but then give an Error as well: Response: Error Message: Did not find extension @hints This should not be the case, even if there were no include => lines it should still end with a EventList: Complete response and not generate an error. | ||
| Comments: | By: Jaco Kroon (jkroon) 2012-10-30 09:04:14.719-0500 It turns out that manager_get_header will never return NULL, resulting in the error check detecting that a Exten: header was supplied, since there are no extensions the counter being checked is thus zero as well, resulting in the inappropriate error. This patch fixes it, and also corrects the incorrect check for a supplied context (not that it's particularly likely to ever trigger). By: Jaco Kroon (jkroon) 2012-10-30 10:04:07.336-0500 A more comprehensive patch. | ||