Summary:	ASTERISK-20752: [patch] - ringing/progress on branched calls not working correctly on some branched calls
Reporter:	Marcus Hunger (fnordian)	Labels:	patch
Date Opened:	2012-11-28 09:48:40.000-0600	Date Closed:
Priority:	Minor	Regression?	No
Status:	Open/New	Components:	Applications/app_dial Channels/chan_sip/General
Versions:	10.8.0 13.18.4	Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) branchedprogress_cleanedup.patch ( 1) branchedprogress.patch
Description:	There are certain call-scenarios where transmitting of ringing-information fails on asterisk. 1) a branched call, first leg replies 486 immediately, second leg replies with 183 first, 180 after it. caller hears silence since progress frames are dropped and no ringing-generator is activated. 2) similar to 1), branched call, first leg replies 486, second and third legs reply 183 and 180. the calling leg is established already. this behavior is shown at least by asterisk version 1.6 and 10.*. i was not able to test it with 11 yet. A patch fixing this issue for me will be attached.
Comments:	By: Marcus Hunger (fnordian) 2012-11-28 09:50:39.342-0600 asterisk 10.8 By: Rusty Newton (rnewton) 2012-12-03 20:14:49.416-0600 Thanks. Patches for 11 and Trunk would be awesome.  If you already have access to reviewboard(https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage), you'll want to post the patches on there for review. You can request access from 'mjordan at digium dot com' if you don't currently have access. By: Richard Mudgett (rmudgett) 2012-12-04 10:42:15.698-0600 You will also need to follow the coding guidelines: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines By: Rusty Newton (rnewton) 2013-01-08 12:25:08.206-0600 Can you verify that your patch follows the coding guidelines and perhaps have someone else test it out to confirm the fix? By: Marcus Hunger (fnordian) 2013-01-09 06:16:43.100-0600 Due to lack of time I can only confirm that the patch is working for us. We were testing 1.6, 10.* and 11. I haven't checked the patch to see if it fits the asterisk coding guidelines. Perhaps I will find some time to do this in about a week. By: Rusty Newton (rnewton) 2013-01-31 13:31:24.948-0600 Keeping this in feedback, until coding guidelines are verified, plus it would be nice to get Asterisk 11 full logs with VERBOSE and DEBUG on demonstrating exact behavior. This will make it easier to reproduce when testing. By: Jan Juergens (j_juergens) 2013-10-10 08:23:36.695-0500 Since we had some more trouble with inband ringback in recent Asterisk versions, we had to fix the original patch in app_dial.c. We also took a look at the coding guidelines. Here is a revised version of the original patch. By: Rusty Newton (rnewton) 2013-10-28 08:55:53.901-0500 Thanks Jan!