[Home]

Summary:ASTERISK-20841: fromdomain not honored on outbound INVITE request
Reporter:Kelly Goedert (kgoedert)Labels:
Date Opened:2012-12-27 09:06:45.000-0600Date Closed:2014-03-24 16:42:19
Priority:MajorRegression?
Status:Closed/CompleteComponents:Channels/chan_sip/Interoperability
Versions:1.8.20.0 11.0.1 Frequency of
Occurrence
Constant
Related
Issues:
is duplicated byASTERISK-21919 Originate request cause an INVITE from "anonymous.invalid" domain
Environment:ubuntu 12.04Attachments:( 0) chan_sip_11.7.0.patch
( 1) debug.txt
Description:From David:

{quote}

frumuser is now working, but the "presentation not allowed" status is still overriding the from domain. I think that is a bug, but it probably doesn't affect that many people as most ITSPs probably don't check the domain part. The easiest to use ones rely on the IP address, and don't check the user, either. The main advantage of matching on From (type=user in Asterisk terms - but on the other side of the trunk) is that you can use multiple single user accounts, rather than a single business account.

You may be able to get round it by forcing presentation allowed in the dialplan, or by turning off RPID (so you can't pass caller ID at all).

However, I think you should report this as a bug.

{quote}

http://forums.digium.com/viewtopic.php?f=1&t=85254&start=0&sid=e5fa9f8ef227109f99d7413980fbb0a5
Comments:By: David Woolley (davidw) 2013-01-02 06:30:38.512-0600

The reportable problem here not specifically to do with originate, and the forbidden is just a secondary consequence.

The problem is that fromdomain appears to be being overridden by the presence of a caller ID with presentation not allowed (possibly in conjunction with the use of RPID).  This also appears to be taking precedence over fromuser, although there was a workaround for that.

As the main use of fromuser and fromdomain are to satisfy ITSP client identification requirements, they need to have the highest priority for setting the From: header.

Note that I am inferring that presentation not allowed is set, from the From header values that are being used.

By: Rusty Newton (rnewton) 2013-01-03 17:39:23.658-0600

Kelly, please read through https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines and follow the guidelines. Additionally follow David Woolley's analysis above for detailing out your bug report.

Please attach any debug, packet captures or asterisk logs as separate files to the issue.

By: Kelly Goedert (kgoedert) 2013-01-07 04:14:59.587-0600

Debug set on level 5

By: Matt Jordan (mjordan) 2013-01-14 16:14:15.400-0600

In the future, do *not* file a bug report and just paste a link to a forum post. Failure to follow the issue reporting guidelines will result in the issue being closed. There's a big check box when you first open an issue that asks if you have read them; clearly you did not. The only way this issue has any of the information needed for developers to fix it is due to David's work (thank you David).

While we appreciate everyone who reports bugs, not doing basic due diligence in providing the information to bug marshals results in problems not getting fixed, which isn't helpful for anyone.

By: Dmitry Panov (dmitry.panov) 2013-02-17 15:06:09.470-0600

I don't have in-depth knowledge of asterisk internals, but a quick look at the code resulted in the following patch which fixed the problem for me:

*\[EDIT: Inline patch removed by mjordan \]*



By: David Woolley (davidw) 2013-02-19 06:20:12.131-0600

Patches as comments are not accepted.  They need to be done as attachments, marked as code contributions, after you have agreed to licence them to Digium, using the Sign a Licence option, at the top of the form.

By: fprior (fprior) 2013-07-02 08:53:46.363-0500

I have signed a contract with my ITSP but I cannot use its services.
Can I do anything to help in the solution of this problem ?
Thank you.

By: Matt Jordan (mjordan) 2013-07-02 10:32:51.974-0500

As David mentioned, we cannot accept patches without them being attached to the issue in unified diff format and a valid license contributor agreement signed. As such, I've removed the patch that was inline in Dmitry's comment.

Issues with valid patches are typically handled much faster.

Otherwise, issues are put in the queue for development and handled as resources become available.

By: Matt Jordan (mjordan) 2013-07-02 10:33:42.054-0500

Dmitry: if you'd like to attach your patch after signing a license contributor agreement, that would be hugely appreciated. Thanks!

By: fprior (fprior) 2013-07-08 14:56:43.603-0500

I tried code proposed by Dmitry and it solved my issue.
I have signed a license contributor agreement: can I attach patch in his stead ?
I want to speed up the resolution but without wishing to take away any merit from the work of Dmitry.

By: Matt Jordan (mjordan) 2013-07-08 15:16:36.455-0500

As Dmitry contributed the patch, that's up to him.

By: Sta Retji (staretji) 2014-02-14 08:06:46.944-0600

Any chance that this will be resolved soon?