| Summary: | ASTERISK-21091: Add 0x144 skinny support | ||
| Reporter: | snuffy (snuffy) | Labels: | |
| Date Opened: | 2013-02-13 20:32:41.000-0600 | Date Closed: | 2013-02-25 00:46:18.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_skinny Channels/chan_skinny/NewFeature |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) skinny-144-pkt.diff ( 1) skinny-prinotify02.diff | |
| Description: | Add the 0x144 packet to skinny.
This allows for showing of inbound caller in the prompt section of the phone. If phone is displaying 'x Missed calls' this packet will replace that for a specified timeout with the person trying to call them. (Defaults to 10 seconds) | ||
| Comments: | By: snuffy (snuffy) 2013-02-13 20:34:41.571-0600 Ideally this patch would supplement the 145 respect callerid. But this diff can be applied without it. By: Rusty Newton (rnewton) 2013-02-15 09:49:30.857-0600 Thanks for the contribution. I've assigned this to Damien Wedhorn who typically maintains chan_skinny. He will likely review your patch and provide feedback. By: Damien Wedhorn (wedhorn) 2013-02-15 17:23:49.630-0600 Big diff based on snuffs. Included packets for <v17 protocol and renamed stuff to align with these. Also added a clear (operates on both <17 and >=17. And added skinny message cli so we can push and clear messages from the cli. Using cli function, timeout and priority are correct for both functions. Some notes about priorities. The actual message displayed will be the lower priority (ie closer to zero). When a priority is timed out or cleared, the next highest will be displayed (assuming it hasn't timed out. Priority level 6 is a permanent message on protocol<17 that can only be cleared by offhooking the device (irrespective of timeout, which appears to be ignored. Priority 6 appears a normal message if protocol >=17. By: snuffy (snuffy) 2013-02-24 22:55:10.295-0600 Looks good.. works for me Can remove the update to the 'complete_skinny_device'.. @@ -3740,8 +3841,10 @@ also needs update to the diff to apply cleanly since service_url.. @@ -1173,6 +1194,9 @@ 1 other very minor thing.. 'for(' missing space line 171 of diff | ||