[Home]

Summary:ASTERISK-21094: MixMonitorMute mutes through stream if already slinear (e.g. Originate)
Reporter:David Woolley (davidw)Labels:
Date Opened:2013-02-14 11:02:20.000-0600Date Closed:2017-02-02 11:10:15.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_mixmonitor
Versions:1.8.20.1 Frequency of
Occurrence
Constant
Related
Issues:
Environment:CentOS 5.3. VMWare.Attachments:( 0) ASTERISK-21094-Patch-1.8-1.txt
Description:We backported MixMonitorMute to 1.6.1 and found a problem that, according to my code reading still exists in the 1.8 branch SVN version, namely that, if the codec is already slinear, using MixMonitorMute causes the orignal media stream to be silenced, as well as the monitored stream.

We are using MixMonitor on queues.  If the incoming call on the queue arrives from a normal channel (in our case a local channel instantiated from a normal channel), MixMonitorMute works correctly, and replaces the audio on the recording by an equivalent period of silence.

If the call on the queue is initiated by AMI Originate (again via a local channel), the through media in both directions is also replaced by equivalent silence.  For the avoidance of doubt, these are frames containing silence, not the absence of frames.

MixMonitorMute is applied in both directions.

Comments:By: David Woolley (davidw) 2013-02-19 08:57:43.123-0600

Patch relative to the current branch 1.8 SVN.  This is a forward port of a backport, but the backport was clean.

We have only exercised the both case and we are only ever likely to exercise this in the context of MixMonitor.

By: Sean Bright (seanbright) 2013-08-14 08:03:26.867-0500

This patch resolved the issue for me on 1.8 SVN.

By: Friendly Automation (friendly-automation) 2017-02-02 11:10:16.376-0600

Change 4863 merged by Joshua Colp:
audiohooks:  Muting a hook can mute underlying frames

[https://gerrit.asterisk.org/4863|https://gerrit.asterisk.org/4863]

By: Friendly Automation (friendly-automation) 2017-02-02 11:52:13.937-0600

Change 4864 merged by zuul:
audiohooks:  Muting a hook can mute underlying frames

[https://gerrit.asterisk.org/4864|https://gerrit.asterisk.org/4864]

By: Friendly Automation (friendly-automation) 2017-02-02 11:52:16.297-0600

Change 4865 merged by zuul:
audiohooks:  Muting a hook can mute underlying frames

[https://gerrit.asterisk.org/4865|https://gerrit.asterisk.org/4865]