| Summary: | ASTERISK-21224: [patch] Skinny groupPickup issues | ||
| Reporter: | Damien Wedhorn (wedhorn) | Labels: | patch |
| Date Opened: | 2013-03-08 00:48:22.000-0600 | Date Closed: | |
| Priority: | Major | Regression? | |
| Status: | Open/New | Components: | Channels/chan_skinny |
| Versions: | SVN 13.18.4 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) skinny-pickupconf01.diff ( 1) skinny-pickupconf02.diff ( 2) skinny-pickupconf03.diff | |
| Description: | Skinny segfaults unless both pickupgroup and callgroup are specified. | ||
| Comments: | By: Damien Wedhorn (wedhorn) 2013-03-08 00:50:17.560-0600 Small patch, sets callgroup to pickupgroup if callgroup left blank. Also disables the gpickup if no pickupgroup specified. Could probably grey out the softkey as well. By: Damien Wedhorn (wedhorn) 2013-03-14 15:20:13.525-0500 New patch (02) that grey's out the gpickup key when not set. Added the (soft)keymask to line given that we can have different setups on each line (eg one line may have pickup and the other doesn't). Had to add a transmit softkeyset to ONHOOK to ensure the default onhook keyset gpickup is appropriately greyed. The default keyset is based on the line you'd get if you lifted up the receiver. May want to rethink gpickup when activated from an onhook device to possibly iterate through available lines. By: Damien Wedhorn (wedhorn) 2013-03-15 13:52:22.671-0500 Small revision to 02.diff. Moves the setting of the l->Keymask from sub config to line config. | ||