Asterisk
  1. Asterisk
  2. ASTERISK-2171

When making a dynamic conference, no protection against duplicate conference numbers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      2200
    • Regression:
      No

      Description

      If 1 user creates a dynamic conference, say ASTERISK-197
      then if some other user making a dynamic conference that
      also decides to use number 200 will not get a message saying that conference number already in use. Instead, the
      user is joined into the already existing conference.

      At a minimum, I would have expected it to say that the
      conference number is in use, would I like to join it or
      instead enter a new conference number.

                • ADDITIONAL INFORMATION ******

      Asterisk CVS-HEAD-07/28/04-10:39:09
      Fedora Core 1

        Activity

        Hide
        edgar added a comment -

        I just figured out how to create dynamic conferences with a
        pin(option D instead of d).

        That interacts with my current bug report in this way:

        When the 2nd user attempts to create conference number 200(which
        was already created with a pin by the first user) asterisk now
        complains about an invalid pin for the conference and asks for a
        conference number.

        That is obviously not correct even if ya'll decide that my
        'bug' is actually a 'feature'!

        Show
        edgar added a comment - I just figured out how to create dynamic conferences with a pin(option D instead of d). That interacts with my current bug report in this way: When the 2nd user attempts to create conference number 200(which was already created with a pin by the first user) asterisk now complains about an invalid pin for the conference and asks for a conference number. That is obviously not correct even if ya'll decide that my 'bug' is actually a 'feature'!
        Hide
        Mark Spencer added a comment -

        Actually, the idea is to be able to have the conference be created dynamically if it doesn't already exist. That is the correct behavior.

        Show
        Mark Spencer added a comment - Actually, the idea is to be able to have the conference be created dynamically if it doesn't already exist. That is the correct behavior.
        Hide
        edgar added a comment -

        If the correct behaviour is to put the 2nd person into the existing conference,
        then should it not prompt you for the conference's PIN instead of just saying
        'invalid PIN' and asking for a new conference number?

        Right now someone would have to hang up, and dial whatever extension is set
        up for entering any conference number and PIN, i.e. meetme() with no options
        set. That at least seems inconsistent - perhaps the code for assigning PINs
        to dynamic conferences was added by someone that didn't know this was the
        behaviour?

        Anyway, I've decided to get around this by not letting the user choose
        the conference room number (I'm using the 'e' option with the 'D' option).
        I will also add to the wiki some info on this behaviour.

        Show
        edgar added a comment - If the correct behaviour is to put the 2nd person into the existing conference, then should it not prompt you for the conference's PIN instead of just saying 'invalid PIN' and asking for a new conference number? Right now someone would have to hang up, and dial whatever extension is set up for entering any conference number and PIN, i.e. meetme() with no options set. That at least seems inconsistent - perhaps the code for assigning PINs to dynamic conferences was added by someone that didn't know this was the behaviour? Anyway, I've decided to get around this by not letting the user choose the conference room number (I'm using the 'e' option with the 'D' option). I will also add to the wiki some info on this behaviour.
        Hide
        Mark Spencer added a comment -

        Well generally you should be using 'D' only once per conference and 'd' the remaining times, but I went ahead and modified app_meetme to basically override your 'D' and change the behavior to that of 'd' if that's what should happen.

        For future bugs, please read the bug guidelines before submitting a bug, in order to better understand what is considered MAJOR vs. MINOR vs. TWEAK, etc.

        Show
        Mark Spencer added a comment - Well generally you should be using 'D' only once per conference and 'd' the remaining times, but I went ahead and modified app_meetme to basically override your 'D' and change the behavior to that of 'd' if that's what should happen. For future bugs, please read the bug guidelines before submitting a bug, in order to better understand what is considered MAJOR vs. MINOR vs. TWEAK, etc.
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 3567

        U trunk/apps/app_meetme.c

        ------------------------------------------------------------------------
        r3567 | markster | 2008-01-15 15:04:27 -0600 (Tue, 15 Jan 2008) | 2 lines

        Correct for user selecting 'D' when they should be selecting 'd' (bug ASTERISK-2171)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=3567

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 3567 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r3567 | markster | 2008-01-15 15:04:27 -0600 (Tue, 15 Jan 2008) | 2 lines Correct for user selecting 'D' when they should be selecting 'd' (bug ASTERISK-2171 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=3567

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development