Summary: | ASTERISK-21816: [patch] OpenBSD fix for UUID | ||
Reporter: | snuffy (snuffy) | Labels: | |
Date Opened: | 2013-05-24 07:09:06 | Date Closed: | 2013-06-03 11:07:03 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Core/BuildSystem |
Versions: | 12 | Frequency of Occurrence | Constant |
Related Issues: | |||
Environment: | openbsd 5.3 x86_64 | Attachments: | ( 0) obsd-ast.txt ( 1) obsd-uuid.diff ( 2) uuid-autoconf-fix.diff ( 3) uuid-autoconf-fix-v2.diff |
Description: | No default UUID within OpenBSD.
ossp-uuid = no good (no generate function) (-luuid) e2fstools = correct uuid.. in correct location uuid/uuid.h (-le2fs-uuid) This adds a check for -le2fs-uuid, alters the configure error msg to check against both libs before failing. | ||
Comments: | By: David M. Lee (dlee) 2013-05-24 16:35:51.024-0500 Your patch fixes the configure check, but doesn't change the linker flag that's actually used (since it's hard coded in main/Makefile to -luuid). So I think it may configure, but fail to link. I had similar issues on OS X (but didn't know it until your comment in #asterisk-dev the other day). I'll attach an updated patch that should fix things for both OpenBSD and OS X. Mind checking it out for me? By: David M. Lee (dlee) 2013-05-24 16:37:53.402-0500 Autoconf fix for finding UUID support in somewhere other than libuuid. Be sure to run ./bootstrap.sh to regen the configure script. By: snuffy (snuffy) 2013-05-26 22:09:02.565-0500 Sorry, forgot to post the re-gen'd configure. Also good catch on my error missing changes Makefile :) By: David M. Lee (dlee) 2013-05-29 09:44:44.106-0500 @snuffy - I take it, then, that my patch works for you? By: snuffy (snuffy) 2013-05-30 19:19:10.335-0500 You missed changing '-luuid' to '-le2fs-uuid' Works otherwise By: snuffy (snuffy) 2013-05-30 19:22:59.649-0500 also have another error/issue when building asterisk. It seems like when it goes to do the final stuff it dies.. (taking part of my ldconfig set with it) I have to manually do ldconfig -m /usr/local/lib to get it to finish the compile.. Attached a text dump. It works fine on the second try (after re-fixing my ldconfig paths) and links all the way through. By: snuffy (snuffy) 2013-05-30 19:27:39.841-0500 File contains failure + second run showing final linkage working By: David M. Lee (dlee) 2013-06-03 09:22:49.724-0500 @snuffy - No idea what's going on with your second problem. It's either something specific to your environment, or a separate issue. I don't think it's related to the UUID fix. By: David M. Lee (dlee) 2013-06-03 09:31:53.392-0500 Heh. The final \[-l\{libname\}\] is actually unnecessary, since the libname is specified as the second param. The final param is extra-libs that might be needed for linking. By: snuffy (snuffy) 2013-06-04 18:32:39.212-0500 Well the current patches work fine. re: ldconfig path getting trashed.. just hoped u might know a reason. Not reason to hold off committing. |