[Home]

Summary:ASTERISK-21826: [patch] Bad queue_log entry when removed member from queue via CLI
Reporter:Oscar Esteve (oscares)Labels:
Date Opened:2013-05-27 14:21:40Date Closed:2013-10-22 14:04:03
Priority:MajorRegression?
Status:Closed/CompleteComponents:Applications/app_queue
Versions:SVN Frequency of
Occurrence
Constant
Related
Issues:
Environment:Asterisk SVN-trunk-r389827 currently running on debianAttachments:( 0) fix_membername.diff
Description:If log_membername_as_agent is set to yes at queues.conf to report the queuemember name instead the member interface, when added a member with CLI:
{noformat}
*CLI> queue add member SIP/oscar to markq penalty 1 as oscar
Added interface 'SIP/oscar' to queue 'markq'
{noformat}
queue_log entry:
{noformat}
1369682091|CLI|markq|oscar|ADDMEMBER|
{noformat}

And when removed it:
{noformat}
*CLI> queue remove member SIP/oscar from markq
Removed interface SIP/oscar from queue 'markq'
{noformat}
queue_log entry:
{noformat}
1369682167|CLI|markq|SIP/oscar|REMOVEMEMBER|
{noformat}
note the queuemember field is really the interface not the queuename.
Comments:By: Oscar Esteve (oscares) 2013-05-27 14:49:04.152-0500

Fix patch


[edit: removed inline patch]

By: Michael L. Young (elguero) 2013-05-28 11:02:55.176-0500

Oscar,

Thanks for the code submission.  Unfortunately, we cannot accept inline code submissions.  Please sign the license agreement and attach your patch as a code submission.

https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines#AsteriskIssueGuidelines-PatchandCodesubmission

Thanks

By: Oscar Esteve (oscares) 2013-05-28 15:43:02.896-0500

Changed the call of find_member_by_queuename_and_interface method before remove member action, if call it after remove it, isn't possible find the member, was removed ¡¡