[Home]

Summary:ASTERISK-21932: [patch] ast_tls_cert: don't re-create generated files
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2013-06-20 12:08:53Date Closed:2013-07-02 03:32:01
Priority:MinorRegression?
Status:Closed/CompleteComponents:Contrib/General
Versions:11.4.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) diff
Description:ast_tls_cert is a script that creates a simple CA (certification authority), which is handy when experimenting with TLS.

If you run:

ast_tls_cert # generate default certificate
ast_tls_cert -C some-host -o some-host

the first run will generate cat.cfg, ca.crt and ca.key , but the second run will run over them, which is counter-intuitive.

This patch makes the script use the existing CA files if they already exist.
Comments:By: Rusty Newton (rnewton) 2013-06-25 19:04:11.561-0500

Hey Tzafrir!  Looks like you were going to attach a patch.  I don't see one attached.  Can you try re-attaching the file?

By: Tzafrir Cohen (tzafrir) 2013-06-26 06:50:04.669-0500

Oops. Now attached.

By: Rusty Newton (rnewton) 2013-06-26 10:17:37.121-0500

Thanks!

By: Matt Jordan (mjordan) 2013-07-01 20:03:49.594-0500

Looks good to me - if you want to go ahead and commit it, that'd be great