Summary: | ASTERISK-22197: [patch] Queuelog EXITWITHKEY only two of four parameters | ||||
Reporter: | Dalius M. (mdalius) | Labels: | |||
Date Opened: | 2013-07-25 06:26:29 | Date Closed: | 2013-10-06 12:09:02 | ||
Priority: | Minor | Regression? | Yes | ||
Status: | Closed/Complete | Components: | Applications/app_queue | ||
Versions: | 1.8.23.0 11.5.0 | Frequency of Occurrence | Constant | ||
Related Issues: |
| ||||
Environment: | Attachments: | ( 0) asterisk-22197-q-log-exitwithkey.diff ( 1) extensions.conf ( 2) full_log.txt ( 3) queue_log.txt ( 4) queues.conf | |||
Description: | Asterisk writes to queuelog only two parameters for EXITWITHKEY event, e.g.:
EXITWITHKEY|8|1 In "Asteriskā¢: The Definitive Guide book" there is described that "Four parameters are recorded: the key used to exit the queue, the position of the caller in the queue upon exit, the original position the caller entered the queue at, and the amount of time the caller was waiting in the queue." So I expect that in queuelog should be e.g.: EXITWITHKEY|8|1|1|5 | ||||
Comments: | By: Michael L. Young (elguero) 2013-07-25 11:17:13.018-0500 Wow... tracked this back to commit r75977. It appears that those extra parameters used to be logged before that patch went in. By: Michael L. Young (elguero) 2013-07-25 11:41:24.946-0500 Commit r62462 added those extra parameters but when r75969 was merged from 1.4 into trunk (r75977), things went back to logging only the 2 parameters. In 1.4, those two extra parameters were not logged. Therefore, this is a regression and the documentation is actually correct. Those two extra parameters should be getting reported. Please try the attached patch, [^asterisk-22197-q-log-exitwithkey.diff], and report back. Thanks By: Dalius M. (mdalius) 2013-07-26 06:27:13.237-0500 I have applied patch. Everything works as expected. By: Dalius M. (mdalius) 2013-09-30 09:40:05.795-0500 When this will be adapted to the stable release? By: Michael L. Young (elguero) 2013-10-03 16:13:57.766-0500 Dalius, sorry for the tardiness with moving this forward. A review was just created and as soon as it gets approval, it can be merged in. Thanks for the reminder. |