[Home]

Summary:ASTERISK-22239: [patch] Missing extra line break between peers when running AMI action SIPPeers
Reporter:Jacek Konieczny (jkonieczny)Labels:
Date Opened:2013-08-01 08:10:58Date Closed:2013-08-05 14:56:01
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:1.8.23.0 Frequency of
Occurrence		Constant
Related
Issues:
is caused byASTERISK-21466 [patch] [crash] command (sip show peers) crashes Asterisk with ~3500 registered peers
is duplicated byASTERISK-22348 Action "sippeers" returns incorrect XML on Manager MXML interface
Environment:Attachments:( 0) asterisk-ami_sippeers_separator.patch
Description:Results of AMI 'Action: SIPPeers' are returned without blank lines between events. This break parsers which expect the empty lines.
The '\r\n\r\n' sequences used to be there in older 1.8.x releasese, especially in 1.8.21.0.

The regression seems to be introduced in r387133.


Example:

{noformat}
Action: SIPPeers

Response: Success
EventList: start
Message: Peer status list will follow

Event: PeerEntry
Channeltype: SIP
ObjectName: dev1n1
ChanObjectType: peer
IPaddress: 10.28.45.27
IPport: 5060
Dynamic: no
Forcerport: yes
VideoSupport: no
TextSupport: no
ACL: no
Status: UNREACHABLE
RealtimeDevice: no
Event: PeerEntry
Channeltype: SIP
ObjectName: dev1n2
ChanObjectType: peer
IPaddress: 10.28.45.72
IPport: 5060
Dynamic: no
Forcerport: yes
VideoSupport: no
TextSupport: no
ACL: no
Status: Unmonitored
RealtimeDevice: no
Event: PeerlistComplete
EventList: Complete
ListItems: 2
{noformat}

Comments:By: Jacek Konieczny (jkonieczny) 2013-08-01 09:39:36.727-0500

This seems to fix the problem.
By: Michael L. Young (elguero) 2013-08-01 13:11:12.371-0500

Jacek,

Thanks for tracking this down.  You are correct.  The fix for ASTERISK-21466 accidentally removed the extra line break.