[Home]

Summary:ASTERISK-22310: Improve error message 'Not a wav file '... in format_wav.c; current message is ambiguous
Reporter:Jim Credland (jimcredland)Labels:
Date Opened:2013-08-18 07:27:48Date Closed:2014-02-05 17:11:02.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Documentation Formats/format_wav
Versions:11.5.0 Frequency of
Occurrence
Related
Issues:
Environment:AllAttachments:
Description:The following error message lies.  Many things are WAV files which do not contain 1 in the format field.  

if (ltohs(format) != 1) {
ast_log(LOG_WARNING, "Not a wav file %d\n", ltohs(format));

Given how unusual the .WAV vs. .wav distinction is I'd go for:  "Not a supported wav file format (%d). Only PCM encoded versions are supported with a lower-case '.wav' extension."

Which would be helpful.
Comments:By: Rusty Newton (rnewton) 2013-08-19 13:31:29.494-0500

Normally we would require a patch, but it's trivial in this case. Thanks for the report. I agree that this message should be more specific.
By: Jim Credland (jimcredland) 2013-08-19 14:29:16.604-0500

Please.  

It caused me lots of headache yesterday.  I now know more about the WAV file format that I want to.  
:)
By: Rusty Newton (rnewton) 2014-02-05 16:07:36.203-0600

I have a patch on reviewboard: https://reviewboard.asterisk.org/r/3188/
By: Rusty Newton (rnewton) 2014-02-05 17:11:36.665-0600

Fixed in all supported branches.