Summary: | ASTERISK-22498: [patch]Create functions to manipulate SIP headers when using PJSIP stack | ||
Reporter: | George Joseph (gjoseph) | Labels: | |
Date Opened: | 2013-09-10 10:16:53 | Date Closed: | 2013-10-08 18:03:03 |
Priority: | Major | Regression? | |
Status: | Closed/Complete | Components: | Resources/res_pjsip |
Versions: | SVN | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ( 0) res_pjsip_header_funcs_v1.patch | |
Description: | Create the PJSIP equivalents of SIP_HEADER and SipAddHeader.
I'm working on this myself. Should be ready for an initial review this week. | ||
Comments: | By: Rusty Newton (rnewton) 2013-09-10 18:16:35.685-0500 Thanks! New features go into Trunk, so I changed the Affects Version to SVN. By: Rusty Newton (rnewton) 2013-09-10 18:18:13.522-0500 When you have the code posted, hit the "Send Back" or "Enter Feedback" button, so we'll see it. Thanks! By: George Joseph (gjoseph) 2013-09-15 12:57:43.413-0500 Ok, first cut. Rather than cloning the incoming pjsip_msg or using pjsip_msg to accumulate the outgoing headers, I used a simple AST_LIST. There was a lot of overhead with the clone functions and some tricky behavior with the pjsip_msg/pjsip_hdr internal lists. Using the AST_LISTs cut down on both instructions and memory. By: George Joseph (gjoseph) 2013-09-15 12:58:22.249-0500 Patch v1 added. By: Matt Jordan (mjordan) 2013-09-15 17:42:56.462-0500 Rusty: FYI, as we announced, new features that deal specifically with the new PJSIP stack or the APIs introduced in Asterisk 12 are fair game for the 12 branch as well - although once that gets "officially released", any new features will require tests. See [Software Configuration Management Policies|https://wiki.asterisk.org/wiki/display/AST/Software+Configuration+Management+Policies] - which got updated as a result of that announcement. George: feel free to push this up to review board whenever you'd like. By: Rusty Newton (rnewton) 2013-09-23 22:16:30.160-0500 Matt, that's right! Whoops. I'll keep an eye out. |