[Home]

Summary:ASTERISK-22790: check_modem_rate() may return incorrect rate for V.27
Reporter:not here (looserouting)Labels:
Date Opened:2013-10-29 07:38:47Date Closed:2014-01-16 11:30:01.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Resources/res_fax
Versions:11.6.0 Frequency of
Occurrence
Related
Issues:
causesASTERISK-23231 Since 405693 If we have res_fax.conf file set to minrate=2400, then res_fax refuse to load
causesASTERISK-24955 res_fax: v.27ter support baud rate of 2400, which is disallowed in res_fax's check_modem_rate
is related toASTERISK-22842 V29 is incompatible with minrate setting 2400
Environment:Attachments:( 0) res_fax.txt
Description:regarding to wikipedia(and others) "The new V.27ter and V.32 standards were able to transmit 4 bits per symbol, at a rate of 1,200 or 2,400 baud, giving an effective bit rate of 4,800 or 9,600 bit/s"

so in case the rate is 2400 or 9600 the function may return the wrong  value.

Comments:By: Matt Jordan (mjordan) 2013-10-29 09:09:21.972-0500

Thank you for taking the time to report this bug and helping to make Asterisk better. Unfortunately, we cannot work on this bug because your description did not include enough information. You may find it helpful to read the Asterisk Issue Guidelines http://www.asterisk.org/developers/bug-guidelines. We would be grateful if you would then provide a more complete description of the problem. At a minimum, we need:

1. the specific steps or actions you took that caused you to encounter the problem,
2. the behavior you expected, and
3. the behavior you actually encountered (in as much detail as possible).

This likely includes output from the console with debug level logging, a SIP trace (if this is SIP related), and configuration information such as dialplan (e.g. extensions.conf) and channel configuration (e.g. sip.conf). Thanks!



By: not here (looserouting) 2013-10-29 09:35:52.396-0500

diff file

By: not here (looserouting) 2013-10-29 09:40:25.259-0500

I didn't run into an issue. I just read the code and saw it.

The function got 41 lines. please take a quick look.

By: Richard Mudgett (rmudgett) 2013-10-30 11:44:56.406-0500

The attached patch is not marked as a contribution.  If you have signed the license agreement you can mark it as a contribution using the Manage Attachments option in the pull down menu associated with the attachments section.

By: Rusty Newton (rnewton) 2013-10-31 09:34:19.025-0500

Paolo, you'll need to sign the license agreement and re-attach or mark the patch as a contribution.


https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines#AsteriskIssueGuidelines-PatchandCodesubmission

Thanks!

By: not here (looserouting) 2013-10-31 13:10:16.272-0500

i can't mark it as contibution.

Opps an error occured !

java.lang.Exception: Insufficient Permissions!

By: not here (looserouting) 2013-10-31 13:18:24.980-0500

re-attached

By: not here (looserouting) 2013-11-12 09:58:54.506-0600

Licence agreed. Patch re-atacched

By: Rusty Newton (rnewton) 2013-11-12 16:10:08.921-0600

Thanks Paolo.

By: not here (looserouting) 2013-12-09 07:29:45.102-0600

default minrate in res_fax.conf is 2400.
default modems is v17,v27,v29

but a rate of 2400 is only supported by v34, right ?

this means after applying my patch the module cannot be loaded with the standard settings.

[Dec  9 14:24:31] ERROR[10367]: res_fax.c:3888 set_config: 'modems' setting 'V17,V27,V29' is incompatible with 'minrate' setting 2400
[Dec  9 14:24:31] ERROR[10367]: res_fax.c:4153 load_module: failed to load configuration file 'res_fax.conf'


since spandsp isn't always build with v34 support, minrate should be changed.


By: Matt Jordan (mjordan) 2015-04-13 10:45:39.517-0500

In retrospect, this patch was probably wrong.

V.27ter does support 2400 baud rate. See spec at: http://www.itu.int/rec/T-REC-V.27ter-198811-I/en

By: not here (looserouting) 2015-04-13 14:13:05.887-0500

i guess you are right.

the wikipedia page changed but still looks wrong...