Summary:	ASTERISK-22797: [patch]Default values for many iax.conf options , including auth= and trunktimestamps= are not indicated in /configs/iax.conf.sample
Reporter:	Eugene (varnav)	Labels:	patch
Date Opened:	2013-10-31 13:28:01	Date Closed:
Priority:	Minor	Regression?
Status:	Open/New	Components:	Channels/chan_iax2 Documentation
Versions:	SVN 13.0.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Irrelevant	Attachments:	( 0) ASTERISK-22797.patch
Description:	/configs/iax.conf.sample indicates default values for most of variables there. But default values for many variables, like trunktimestamps (line 270) and auth (line 529) are not indicated.
Comments:	By: Rusty Newton (rnewton) 2013-10-31 13:49:59.562-0500 Looks like the defaults are not explicitly indicated for many of the options. Many have a value as an example, but don't indicate whether they are the default or not. Feel free to clarify via source code, or with a developer in #asterisk-dev and provide a documentation patch if you have the time. By: Eugene (varnav) 2013-11-02 03:49:32.532-0500 I've checked sources for default values and attached the patch. I think that would be best if someone double checks this. By: Eugene (varnav) 2013-11-15 00:07:34.648-0600 Please note that patch from ASTERISK-22820 will change default value of 'auth'. By: Rusty Newton (rnewton) 2013-12-12 16:26:10.388-0600 Thanks Eugene! By: Eugene (varnav) 2015-08-11 04:19:10.122-0500 Pls implement this. By: Joshua C. Colp (jcolp) 2015-08-11 05:02:33.148-0500 The process for submitting a patch is documented at https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process#PatchContributionProcess-SomeFrequentlyAskedQuestions and while simply attaching it to the issue is acceptable it's not preferred, as it places the burden on someone else to put it up for code review and take it through the code review process. Taking your patch through the code review process yourself is much faster. By: Eugene (varnav) 2015-08-11 05:53:55.980-0500 Patch in fact is attached By: Joshua C. Colp (jcolp) 2015-08-11 06:03:02.725-0500 Yes, but it's not up for code review. Unless you do it someone else has to, and respond to feedback as it occurs.