[Home]

Summary:ASTERISK-23186: [patch] Add usegmtime option to cel_pgsql
Reporter:Rodrigo Ramirez Norambuena (roramirez)Labels:
Date Opened:2014-01-25 16:38:49.000-0600Date Closed:2015-04-08 06:37:37
Priority:MinorRegression?
Status:Closed/CompleteComponents:CEL/cel_pgsql
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cel_pgsql.c_add_usegmtime.patch
( 1) cel_pgsql.c_add_usegmtime2.patch
Description:Add an option that lets you specify that the timestamps going into PostgreSQL from CEL log should be in GMT instead of local time.
Comments:By: Rusty Newton (rnewton) 2014-01-28 18:22:09.289-0600

Thanks for the patch! One thing I noted, the change to the CHANGES file is incorrect.. you've inserted a note in the "changes from Asterisk 1.8 to 10" section which doesn't make any sense. Seeing as this new feature would go into Trunk (and then Asterisk 13 later on), your note would go at the very top of the file in the "Changes from Asterisk 12 to Asterisk 13" section.



By: Rodrigo Ramirez Norambuena (roramirez) 2014-01-28 20:45:43.148-0600

Added new patch with note on "Changes from Asterisk 12 to Asterisk 13" section

By: Rodrigo Ramirez Norambuena (roramirez) 2015-01-08 14:43:47.409-0600

Hello,

Do you have any update about this?,

If required any change?







By: Matt Jordan (mjordan) 2015-01-19 19:57:44.163-0600

Unfortunately, no Asterisk developer has reviewed the patch yet.

If you'd like to speed up the process, you can submit the patch yourself for code review. Instructions for doing so can be found on the wiki here:

https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process

By: Rodrigo Ramirez Norambuena (roramirez) 2015-03-30 20:22:45.099-0500

Hi Matt, i added the review on https://reviewboard.asterisk.org/r/4571/

Is ok?

By: Matt Jordan (mjordan) 2015-04-08 06:36:00.924-0500

Merged into trunk. Thanks for the contribution!