| Summary: | ASTERISK-23231: Since 405693 If we have res_fax.conf file set to minrate=2400, then res_fax refuse to load | ||||||||||
| Reporter: | David Brillert (aragon) | Labels: | |||||||||
| Date Opened: | 2014-01-31 09:36:23.000-0600 | Date Closed: | 2014-02-27 10:00:03.000-0600 | ||||||||
| Priority: | Major | Regression? | Yes | ||||||||
| Status: | Closed/Complete | Components: | Resources/res_fax | ||||||||
| Versions: | SVN | Frequency of Occurrence | Constant | ||||||||
| Related Issues: |
| ||||||||||
| Environment: | SVN 405693 | Attachments: | ( 0) res_fax-minrate.patch | ||||||||
| Description: | sip*CLI> module load res_fax.so
Unable to load module res_fax.so Command 'module load res_fax.so' failed. [2014-01-31 10:10:55] == Parsing '/etc/asterisk/res_fax.conf': Found [2014-01-31 10:10:55] ERROR[12242]: res_fax.c:3888 set_config: 'modems' setting 'V17,V27,V29' is incompatible with 'minrate' setting 2400 [2014-01-31 10:10:55] ERROR[12242]: res_fax.c:4153 load_module: failed to load configuration file 'res_fax.conf' /etc/asterisk/res_fax.conf ; Generic Fax Application configuration [general] ; Maximum Transmission Rate ; Possible values are { 2400 | 4800 | 7200 | 9600 | 12000 | 14400 } ; Set this value to the maximum desired transfer rate. Default: 14400 maxrate=14400 ; Minimum Transmission Rate ; Possible values are { 2400 | 4800 | 7200 | 9600 | 12000 | 14400 } ; Set this value to the minimum desired transfer rate. Default: 2400 minrate=2400 ; Send Progress/Status events to manager session ; Manager events with 'call' class permissions will receive events indicating the ; steps to initiate a fax session. Fax completion events are always sent to manager ; sessions with 'call' class permissions, regardless of the value of this option. ; Default: no statusevents=yes ; modem capabilities ; Possible values are { v17 | v27 | v29 } ; Set this value to modify the default modem options. Default: v17,v27,v29 modems=v17,v27,v29 ; Enable/disable T.30 ECM (error correction mode) by default. ; Default: Enabled ecm=yes Regression caused by: Revision 405693 - Directory Listing Modified Thu Jan 16 18:57:43 2014 UTC (2 weeks ago) by kharwell res_fax: check_modem_rate() returned incorrect rate for V.27 According to the new standard for V.27 and V.32 they are able to transmit at a bit rate of 4,800 or 9,600. The check_mode_rate function needed to be updated to reflect this. Also, because of this change the default 'minrate' value was updated to be 4800. (closes issue ASTERISK-22790) Reported by: Paolo Compagnini Patches: res_fax.txt uploaded by looserouting (license 6548) ........ Merged revisions 405656 from http://svn.asterisk.org/svn/asterisk/branches/1.8 | ||||||||||
| Comments: | By: Matt Jordan (mjordan) 2014-01-31 09:53:41.086-0600 That isn't a bug. Setting a minimum fax rate of 2400 is invalid with a modem capability of v27. v27 cannot accept the minimum fax rate that you've specified. By: Joel Vandal (joel_vandal) 2014-01-31 10:02:35.531-0600 This will not broke all existing installations ? If the customer already have res_fax.conf file set to minrate=2400, they will have to change it. When loading configuration file, if value is set to 2400, change it to 4800 instead of fail to load the module and display a warning ? By: David Brillert (aragon) 2014-01-31 10:04:04.536-0600 I guess you are right and it's not technically a bug since /usr/share/doc/asterisk11-11.8.0/configs/res_fax.conf.sample minrate=4800 But this is going to break a lot of installs where the default minrate=2400 By: Matt Jordan (mjordan) 2014-01-31 11:11:26.395-0600 That is noted in the UPGRADE.txt file: {quote} from 11.8 to 11.9 * res_fax now returns the correct rates for V.27ter (4800 or 9600 bit/s). Because of this the default settings would not load, so the minrate (minimum transmission rate) option was changed to default to 4800 since that is the minimum rate for v.27 which is included in the default modem options. {quote} While users should read the UPGRADE notes when moving to a version, I will concede that most do not. For the existing branches, we'll look at adding something that fudges the minrate. By: Corey Farrell (coreyfarrell) 2014-02-03 03:26:13.810-0600 res_fax-minrate.patch addresses this issue in two ways: Change on config reload minrate from 2400 to 4800 in response to the regression only. Any config with minrate of 2400 that would fail before r405693 will still fail. Comment out many settings in res_fax.conf.sample. The defaults are set in res_fax.c, so setting the same value in sample config does nothing but make the sample config more fragile. By: Matt Jordan (mjordan) 2014-02-24 12:21:11.496-0600 I'd say Ship It! on your patch Corey. It warns the users, doesn't break functionality, and makes it so that a blind install of the fax configuration doesn't hurt anyone. | ||||||||||