Summary:	ASTERISK-23282: Documentation - Tab completion and CLI usage documentation do not indicate that 'all' is accepted for 'confbridge kick all'
Reporter:	Dorian Logan (dorianlogan)	Labels:
Date Opened:	2014-02-12 08:34:31.000-0600	Date Closed:	2014-04-21 09:58:38
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_confbridge
Versions:	12.0.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Production	Attachments:
Description:	Ref ASTERISK-21827 - this was committed to trunk - but appears to have been lost in the refactoring work.  I am happy update the patch for the new builds but I want to confirm that it will remain in the project or was there another reason for it being backed out.
Comments:	By: Michael L. Young (elguero) 2014-02-12 12:47:36.424-0600 Dorian, When was it backed out?  In looking at the code, it would appear to still be there. By: Michael L. Young (elguero) 2014-02-12 12:50:12.758-0600 The only thing I can think of, is that, you are not seeing from the cli the "Usage:" mention that "all" can be used as a value for the channel parameter.  Is that what you are seeing missing?  The functionality appears to be there still. By: Dorian Logan (dorianlogan) 2014-02-18 06:50:22.935-0600 I can not see it in the V12 trunk, newer builds or subsequent V11 Asterisk releases. I will double check. By: Richard Mudgett (rmudgett) 2014-02-18 11:44:49.880-0600 Tab completion and CLI usage documentation do not indicate that 'all' is accepted. However, if you issue "confbridge kick all" it will kick all participants in the conference bridge. The AMI ConfbridgeKick action documentation needs to be updated to say that if the Channel header is 'all' then all participants are kicked.  The action response prompts could use some tweaking to indicate that 'all' participants were kicked instead of implying that only one participant was kicked. By: Dorian Logan (dorianlogan) 2014-02-20 04:53:11.239-0600 I can update the code to include the help text - very happy to do that - I just could not see my code in recent SVN checkouts - I see that the structure of the code has changed - I will look again maybe I am just looking in the wrong place! By: Dorian Logan (dorianlogan) 2014-02-20 05:27:42.542-0600 I can see me patch in SVN-trunk-r399405 - but 408499 has no evidence of the change when I look in the source code.  I also have not seen it in any of the 11.x releases.   By: Dorian Logan (dorianlogan) 2014-02-21 05:45:12.582-0600 I have reviewed again I can not find any evidence of my code change or comments - as the code has been refactored - the original patch sumbitted with no longer work I shall build another patch from the V11 branch and submit it to this ticket. By: Dorian Logan (dorianlogan) 2014-02-21 08:06:52.985-0600 I will send a new patch By: Michael L. Young (elguero) 2014-02-21 09:24:57.077-0600 Dorian, this was a new feature.  New features do not go into released branches.  That is why it was committed to trunk only and it should be in Asterisk 12+. If you look at the commit message, your patch was modified to conform with going into trunk (https://issues.asterisk.org/jira/browse/ASTERISK-21827?page=com.atlassian.jira.plugin.ext.subversion:subversion-commits-tabpanel). As Richard pointed out, there are some ares where the documentation could be updated to indicate that 'all' is accepted.  If you want to provide the documentation updates that Richard pointed out, that would be great.  Otherwise, you can wait to see if someone else will help to contribute that. Otherwise, the feature is there and it is working.  Richard has confirmed it and I just confirmed that the feature is working.  It is just not documented very well. By: Dorian Logan (dorianlogan) 2014-02-21 14:01:27.030-0600 Thanks for your explanation and patients with me!  I understand - and look forward to V12!!! Only small frustration is that we are going to be on V11 for quite a while! I will get a patch built to fix the documentation - don't want to leave this 1/2 done! Until is is released in an official build - what versions of what versions of Asterisk should I check out for a production system?  Will it appear in any V11 builds? (I don't mean official ones) By: Michael L. Young (elguero) 2014-02-21 15:16:36.677-0600 Dorian, Asterisk 12 was already released but it is a Standard release.  Asterisk 13 will be the Long Term Supported (LTS) release which will be out at the end of this year.  Asterisk 11 is the current LTS release. What you will probably need to do is maintain your own patch while you are on Asterisk 11.  Just backport the patch that went into trunk and these documentation changes.  That way it will be pretty much the same as in newer versions of Asterisk. Please take a look at this page: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Versions Only you can determine which version you should be running in production according to your setup and requirements.  New features will not show up in Asterisk 11. By: Richard Mudgett (rmudgett) 2014-03-10 17:40:46.448-0500 This issue is a bug for Asterisk 12 and later.  The patch needs to fix the following as I indicated earlier: {quote} Tab completion and CLI usage documentation do not indicate that 'all' is accepted. The AMI ConfbridgeKick action documentation needs to be updated to say that if the Channel header is 'all' then all participants are kicked. The action response prompts could use some tweaking to indicate that 'all' participants were kicked instead of implying that only one participant was kicked. {quote} By: Kinsey Moore (kmoore) 2014-04-21 09:58:38.121-0500 The fixes for the CLI and AMI documentation and responses have been committed to 12 and trunk.