[Home]

Summary:ASTERISK-23293: Testsuite asttest doesn't compile with Lua 5.2
Reporter:George Joseph (gjoseph)Labels:
Date Opened:2014-02-13 00:21:57.000-0600Date Closed:2014-02-13 16:48:23.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Tests/testsuite
Versions:1.8.8.2 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Fedora 20 x86_64 Name : lua Arch : x86_64 Version : 5.2.2 Release : 5.fc20 Attachments:
Description:
asttest fails to compile against Lua 5.2

{code}
$ make
cc -g -D_GNU_SOURCE -Wall `pkg-config --cflags lua5.1 2> /dev/null || pkg-config --cflags lua 2> /dev/null` -Iinclude   -c -o asttest.o asttest.c
make -C lib/lua/luafilesystem-1.4.2
make[1]: Entering directory `/usr/src/asterisk/testsuite/asttest/lib/lua/luafilesystem-1.4.2'
gcc -O2 -Wall -fPIC -W -Waggregate-return -Wcast-align -Wmissing-prototypes -Wnested-externs -Wshadow -Wwrite-strings -pedantic `pkg-config --cflags lua5.1 2> /dev/null || pkg-config --cflags lua 2> /dev/null`   -c -o src/lfs.o src/lfs.c
src/lfs.c:680:30: error: array type has incomplete element type
static const struct luaL_reg fslib[] = {
                             ^
src/lfs.c:680:30: warning: ‘fslib’ defined but not used [-Wunused-variable]
make[1]: *** [src/lfs.o] Error 1
make[1]: Leaving directory `/usr/src/asterisk/testsuite/asttest/lib/lua/luafilesystem-1.4.2'
make: *** [lib/lua/luafilesystem-1.4.2/src/lfs.o] Error 2

{code}
Comments:By: Matt Jordan (mjordan) 2014-02-13 12:58:16.219-0600

Ugh.

Honestly, we're trying to kill the Lua tests off. Someday, we may be able to remove {{asttest}} completely.

How good are you at Lua? :-)
By: George Joseph (gjoseph) 2014-02-13 13:59:26.205-0600

Better than python. :(

I'm OK with marking this as "won't fix" if it's on the way out but I know some tests and run-test itself depend on asttest still.  

Let me take a look at it a little more while I'm backed up waiting for a few other commits to go through.  If it's trivial I'll fix it.


By: George Joseph (gjoseph) 2014-02-13 16:43:56.041-0600

Not promising.  I can get it to compile but it segfaults.
Too much has changed in 5.2 and I'd have to dig down into lua-socket, lua-filesystem and lua-posix.
Not worth it.



By: George Joseph (gjoseph) 2014-02-13 16:48:23.131-0600

Lua test scripts are being deprecated.

By: Alexander Traud (traud) 2018-06-07 11:32:22.412-0500

Just as a note to the curious reader who comes by:
lua-socket, lua-filesystem, and lua-posix are external projects which are still maintained (and Lua 5.3 compatible by now). Some distributions even have them pre-packaged. ‘Just’ asttest itself would need an upgrade. Anyway with some changes, asttest still works in Fedora today as described in ASTERISK-27904.