Summary:	ASTERISK-23324: [patch] - QLOOG commiting Japanese translated prompts
Reporter:	Kevin McCoy (qloogkm)	Labels:
Date Opened:	2014-02-18 09:50:47.000-0600	Date Closed:	2014-06-29 23:01:36
Priority:	Critical	Regression?
Status:	Closed/Complete	Components:	Sounds
Versions:	SVN	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) app_voicemail.c.20140226.jp.patch ( 1) README ( 2) say.c.20140226.jp.patch
Description:	QLOOG commiting Japanese translated prompts
Comments:	By: Rusty Newton (rnewton) 2014-02-19 20:49:06.093-0600 Sean you can hit the "Send Back" or "Enter Feedback" buttons once things have been added on here. By: Kevin McCoy (qloogkm) 2014-02-24 18:26:05.153-0600 Quick question - According to https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process the files contained in the core pack should be exact matches of what's there in English. We have an interesting situation in Japanese where numbers for dates, counting, passwords, and such are all said differently. It's kind of like how you don't say "February twenty-five" in English and you need an extra sound for "twenty-fifth". Is it cool to put these extra counter sounds in the Japanese core bundle? It's definitely the same "core" functionality because it's dates, voicemail counts, etc., we just need more sounds to get there. By: Rusty Newton (rnewton) 2014-02-25 12:00:40.188-0600 Kevin, that is certainly fine. I'll edit the wiki instructions to make it clear that it is fine to deviate where the language requires it for proper understanding. Make sure to include the descriptions of any additional sounds in your core-sounds-jp.txt file as well. (or in the CSV file if you don't provide a .txt already formatted) The key is not to change the file names of any existing sounds. As that could break things for applications within Asterisk that are hardcoded to call specific sound files. Thanks! By: Kevin McCoy (qloogkm) 2014-02-25 18:52:57.222-0600 Thanks Rusty. I should have something for you guys very soon. By: Kevin McCoy (qloogkm) 2014-02-27 04:47:37.626-0600 Rusty another question about the license - I know our company's voice actress is the one who signs it, but just for posterity's sake can she include the company name next to her printed name? You can probably tell by this question that we're down to the small stuff now ;) By: Rusty Newton (rnewton) 2014-02-27 15:14:46.308-0600 I talked with our legal counsel about this and they are modifying the license. It is not currently specific enough for both a scenario where an individual licenses the sounds, and a scenario where an individual represents a company or organization. Once the license is modified I'll let you know and then it should have a spot for to fill in the name of a company being represented. By: Rusty Newton (rnewton) 2014-03-05 09:05:17.003-0600 Kevin, This wiki page: https://wiki.asterisk.org/wiki/display/AST/Asterisk+Soundfiles+Submission+Process and the license form on it has been updated. Now you should have a line to add the company being represented. By: Kevin McCoy (qloogkm) 2014-03-06 04:35:24.785-0600 Rusty, thank you for getting that updated! Below is the link to our release candidate. Have a look/listen and let me know what you think. https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz A couple things to be aware of: 1) A Japanese patch is included with instructions for patching the Asterisk source code. Without this patch, the sounds don't play properly for a lot of things like date/time, voicemail, conferencing, and so forth. I'd like you to consider the patch as part of the submission here if possible. 2) There are some sounds that are identical (beeps, silence) and others that are not useful in Japanese (NATO phonetics "alpha, bravo, charlie..."). We'd like to just leave the original recordings for these. However, we don't have them in 48k wav - just the public 8000hz files that are available on the Asterisk server. Let me know if there's a problem here. 3) We can have the license signed and copied to you as soon as all technical things are cleared. Thanks as always for being so helpful with this! Feels like we're getting close now. By: Kevin McCoy (qloogkm) 2014-03-12 21:43:12.313-0500 Hi Rusty, just wanted to let you know that we have the license signed by the artist and ready to go. Let me know if I can help you with anything else. By: Rusty Newton (rnewton) 2014-03-25 13:10:14.656-0500 Kevin, I still need to review things in more detail, but I do have one thing - you need to attach the patch to the issue and mark it as a code contribution so that it is under the submission agreement license (different than the license for the sound prompts themselves). By: Kevin McCoy (qloogkm) 2014-03-27 04:44:47.280-0500 Here are the files for the patch, designated as code and documentation contributions. By: Kevin McCoy (qloogkm) 2014-04-09 02:58:59.885-0500 Rusty - do you think we'll be able to have this committed before the end of this month? We're quite interested in taking the leap to get this in the official Asterisk packages before Godzilla decimates us all. Japan is counting on you! :) By: Rusty Newton (rnewton) 2014-04-10 14:29:03.647-0500 It is in my queue of things to do! However, bugs come before new sounds for me, and I've had plenty of bugs to reproduce and triage. Now that you have the patches on here under license, you want to put them on reviewboard.asterisk.org to get peer review, here is the process for code submissions that was linked from the sound file submissions page: https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process https://wiki.asterisk.org/wiki/display/AST/Code+Review In the meantime, while you are getting peer review of the code, I promise I'll review the sounds package as far as I can. One thing I can't do is understand or speak Japanese, so I have to assume those are good. I'll check the file arrangements, formats and all that however. By: Kevin McCoy (qloogkm) 2014-04-14 00:42:19.862-0500 Hi Rusty, thanks for your reponse. I went ahead and requested a review at https://reviewboard.asterisk.org/r/3477 By: Kevin McCoy (qloogkm) 2014-05-22 01:13:17.559-0500 The code has been up for review for a while now on the review board and we've fixed all the issues as they were brought up. Are we ready to have this committed? :) By: Rusty Newton (rnewton) 2014-05-22 07:15:45.976-0500 You need at least two "Ship it"s marked on the review to get it committed. That means there is still some reviewing to be done. You can E-mail the dev list and ask if a couple people can do a final review. If you get the "ship its" then I'll ping someone to have them commit it. By: Joshua C. Colp (jcolp) 2014-05-22 10:11:58.732-0500 I've given it one. Unless someone has any qualms we can commit it the beginning of next week. By: Rusty Newton (rnewton) 2014-05-23 16:05:40.267-0500 Kevin bq. Hi Rusty, just wanted to let you know that we have the license signed by the artist and ready to go. For some reason I thought we were still waiting on you for the license. I just saw that in the comments. Please attach the signed license to the issue as well and I'll get that to legal. By: Kevin McCoy (qloogkm) 2014-05-27 20:23:45.978-0500 Rusty - the license agreement has a signature on it and I'd prefer not to have it publicly available as an attachment. I'm going to email it to you, so for all who are tracking this ticket, please consider the license submitted. Edit: Emailed to Matt and Rusty 5/28 10:35 AM By: Michelle Fleming (mpetrone) 2014-05-28 13:04:04.207-0500 We received the license agreement and it is fine to contribute the prompts, thank you. By: Kevin McCoy (qloogkm) 2014-06-01 20:24:21.714-0500 OK, looks like everything should be good to go then. Let me know if there is anything I can do to help, otherwise I will keep an eye out over the next day or two. By: Rusty Newton (rnewton) 2014-06-12 09:49:31.869-0500 I'm trying to coordinate this with the inclusion of some other prompt updates as well to avoid making repeated sounds releases with a lot of redundant effort. Just wanted to let you know that you haven't been forgotten. By: Kevin McCoy (qloogkm) 2014-06-30 20:11:05.150-0500 Hello, I see that Matt made the following comments. Does this mean that we'll have to wait for Asterisk 13 for this to be publicly available? r417591 | mjordan | 2014-06-29 23:00:19 -0500 (Sun, 29 Jun 2014) | 18 lines    app_voicemail, say: Add support for Japanese Language    This patch adds support for the Japanese language to both the say family of  applications, as well as for VoiceMail and VoiceMailMain. A new pack of  language sounds will be released at the same time as the next major version  of Asterisk to support the new language features.    The language features can be enabled using a language code of 'ja' By: Rusty Newton (rnewton) 2014-07-07 09:27:57.192-0500 {quote} Does this mean that we'll have to wait for Asterisk 13 for this to be publicly available? {quote} We'll actually get the sounds made earlier than October. We are making the release as soon as possible. There is a few difficulties due to changes with build dependencies so it isn't a quick process at the moment. I'll be sure to update you as progress is made. By: Dave Bouchard (daveQLOOG) 2014-07-24 00:10:17.609-0500 Thanks for your message. Is there any way we can track the current progress for the next release which will include japanese prompts? By: Kevin McCoy (qloogkm) 2014-08-20 02:12:03.349-0500 An updated version of the prompt wav files is available at: https://www.dropbox.com/s/mrovzqcqgimj05c/asterisk-core-sounds-ja-wav-2014-08-20.tar.gz Please make sure that when the patch and files are committed that these sounds are used since they will fix some format inconsistencies that were in the last bundle. By: Rusty Newton (rnewton) 2014-08-28 11:36:08.955-0500 [~daveQLOOG] and [~qloogkm] we'll be attempting to get a release out today. I'll let you know how it goes. I'll check out your new files and integrate them. By: Rusty Newton (rnewton) 2014-08-29 09:55:06.976-0500 [~daveQLOOG] and [~qloogkm] After triple checking things again for release I looked into your sound bundle at https://www.dropbox.com/s/mrovzqcqgimj05c/asterisk-core-sounds-ja-wav-2014-08-20.tar.gz After running some diffs this appears to be identical to what we have in our sounds trunk. Did you link the right archive, or did we already have the right files on hand from a couple months ago? By: Kevin McCoy (qloogkm) 2014-08-31 21:03:39.045-0500 There were some wav files that were not the right sample rate which would cause errors when running our conversion script, however if the diffs of earlier files you have match exactly what's in the 8-20 file I sent then there shouldn't be any difference. By: Rusty Newton (rnewton) 2014-09-05 09:38:40.881-0500 Thanks I'll double check and move forward. By: Rusty Newton (rnewton) 2014-09-10 07:34:28.563-0500 [~qloogkm] and [~daveQLOOG] , the release has been made. The Japanese prompts should be available via menuselect in SVN of  1.8,11,12,13,Trunk.  Can you test it out and verify things are good? If you run into any issues, please open a new JIRA issue and we'll track it that way. Thanks! By: Kevin McCoy (qloogkm) 2014-09-11 01:55:14.765-0500 Rusty thanks, I checked this morning and everything seems to be working well! By: Rusty Newton (rnewton) 2014-09-19 14:19:30.634-0500 Sounds good!  Also, I'm going to E-mail you guys about a blog post I'll be writing. Thanks again. By: Kevin McCoy (qloogkm) 2014-10-08 20:36:00.892-0500 With regard to the patches on this release, although the Japanese files themselves are selectable in the above language, the patches have not been applied to say.c or voicemail.c except in Asterisk 13. Was there an issue somewhere with getting the patches applied? The files will not play in the correct sequence now in vanilla Asterisk 1.8, 11, or 12 because of this, which will lead to confusion for users of those versions who download the prompts expecting them to work properly. By: Kevin McCoy (qloogkm) 2014-10-20 03:13:21.249-0500 Bump - please let me know what to expect with this, thanks.