| Summary: | ASTERISK-23350: Testsuite: manager/acl-login fails on some platforms | ||
| Reporter: | Corey Farrell (coreyfarrell) | Labels: | |
| Date Opened: | 2014-02-23 01:27:42.000-0600 | Date Closed: | 2014-02-26 09:37:03.000-0600 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Tests/testsuite |
| Versions: | SVN | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Linux ws2 3.11.0-12-generic #19-Ubuntu SMP Wed Oct 9 16:20:46 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux | Attachments: | ( 0) starpy-manager-bindAddress.patch ( 1) testsuite-manager-acl-login-bindAddress.patch |
| Description: | tests/manager/acl-login assumes that an AMI connection to 127.0.0.2 will be sent from 127.0.0.2. On some systems all connections to 127.0.0.x are made from 127.0.0.1 by default.
* starpy/manager.py needs to accept named parameter bindAddress, for use with reactor.connectTCP. * acl-login test needs to specify bindAddress for manager connections. | ||
| Comments: | By: Corey Farrell (coreyfarrell) 2014-02-23 01:31:39.174-0600 git diff for starpy and svn diff for testsuite. The testsuite cannot be updated until starpy manager login supports bindAddress. By: Matt Jordan (mjordan) 2014-02-23 21:47:08.262-0600 I'd say Ship It! on both patches. By: Corey Farrell (coreyfarrell) 2014-02-23 21:50:55.593-0600 For starpy should I send a pull request through github? Also note the testsuite patch probably requires the starpy patch, I'm not sure what would happen with patched testsuite and non-patched starpy. | ||