[Home]

Summary:ASTERISK-23382: [patch]Build System: make -qp can corrupt menuselect-tree and related files
Reporter:Corey Farrell (coreyfarrell)Labels:
Date Opened:2014-02-27 01:22:02.000-0600Date Closed:2014-03-05 09:22:54.000-0600
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) makefile-1.8.patch
Description:Running 'make -qp' while menuselect.makeopts is out of date will cause menuselect-tree to be corrupt.  The problem is that make is used to generate those files, and MAKEFLAGS=qp.  This causes the output of "make -qp" to be included in menuselect-tree.
Comments:By: Corey Farrell (coreyfarrell) 2014-02-27 01:23:37.228-0600

This issue effects SVN 1.8 only, it is not included in 1.8.26-rc1.
By: Walter Doekes (wdoekes) 2014-02-28 10:03:20.787-0600

{noformat}
17:56 < wdoekes> mjordan: ASTERISK-23382 - the embed_modules dependency
stuff breaks 'make -qp' (which is run on tab completion apparently) on
the 1.8 makefile. revert the whole -include menuselect.makeopts ("we
want the MENUSELECT_EMBED var") in 1.8? or implement the
asterisk-11-and-up approach (grep ^MENUSELECT_EMBED=$$)?

17:58 <@mjordan> wdoekes: what was the reason for not using the
asterisk 11 approach initially?

18:13 < wdoekes> mjordan: using grep seemed less elegant than loading
up the variable through the include-directive.

18:20 <@mjordan> wdoekes: I can live with clunky
{noformat}