| Summary: | ASTERISK-23412: Theoretical ref-leak in chan_sip autokill | ||
| Reporter: | Steve Davies (one47) | Labels: | |
| Date Opened: | 2014-03-04 04:14:01.000-0600 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Open/New | Components: | Channels/chan_sip/General |
| Versions: | 1.8.27.0 11.8.0 13.18.4 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Theoretical / Code review | Attachments: | ( 0) theoretical_sip_autokill_fix.diff |
| Description: | While investigating a different ref-count issue, I observed that {code}pvt->autokillid{code} can be prematurely reset to -1 in __sip_autodestruct(), causing a potential ref-leak issue.
IMHO It should only be reset if the call is not going to be rescheduled, and after the lock has been obtained. I have not seen this cause an issue in the wild. | ||
| Comments: | By: Steve Davies (one47) 2014-03-04 04:27:29.858-0600 Untested patch attached to demonstrate the possible issue more clearly. | ||