Asterisk
  1. Asterisk
  2. ASTERISK-2343

[Feature + Patch] E-mail info and list for astcc

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/NewFeature
    • Labels:
      None
    • Mantis ID:
      2375
    • Regression:
      No

      Description

      I have added support for a couple of different features which I required. I'm not sure if I implemented the email support in the best way but it does work.

      1. Astcc can be easily configured to email you the card numbers and specs on the cards whenever new cards are added.

      2. I have added a button under "cards" that will list all cards in the system and give the available info on each one.

        Activity

        Hide
        Mark Spencer added a comment -

        Do you have a disclaimer on file?

        Show
        Mark Spencer added a comment - Do you have a disclaimer on file?
        Hide
        Darren Wiebe added a comment -

        I'm faxing one in right away. I will mail it on Tuesday or Wednesday.

        Show
        Darren Wiebe added a comment - I'm faxing one in right away. I will mail it on Tuesday or Wednesday.
        Hide
        Darren Wiebe added a comment -

        You should have the disclaimer by now.

        Show
        Darren Wiebe added a comment - You should have the disclaimer by now.
        Hide
        Mark Spencer added a comment -

        Looks like a great patch, just one comment...

        Creating a tmp file in /tmp with a fixed or predictable name can be the source of a security problem in which someone points some system file to /tmp and when you open it it gets overwritten. Since you're just sending the output to the mail program, you can also use:

        open (FOO, "|$config

        {mailprog}

        -s 'some subject'") to open the mail program and write to it directly, then just close(FOO) when you're done.

        Show
        Mark Spencer added a comment - Looks like a great patch, just one comment... Creating a tmp file in /tmp with a fixed or predictable name can be the source of a security problem in which someone points some system file to /tmp and when you open it it gets overwritten. Since you're just sending the output to the mail program, you can also use: open (FOO, "|$config {mailprog} -s 'some subject'") to open the mail program and write to it directly, then just close(FOO) when you're done.
        Hide
        Darren Wiebe added a comment -

        Thanks for the tip. I will make a new patch on the weekend.

        Show
        Darren Wiebe added a comment - Thanks for the tip. I will make a new patch on the weekend.
        Hide
        Darren Wiebe added a comment -

        1. I have corrected the method of calling the mail program.

        2. I have added support to specify the length of card numbers you want.

        3. I have added support to insist that the card numbers start with a particular number.

        4. I have added support to add money to cards.

        I'm attaching a new diff file

        Show
        Darren Wiebe added a comment - 1. I have corrected the method of calling the mail program. 2. I have added support to specify the length of card numbers you want. 3. I have added support to insist that the card numbers start with a particular number. 4. I have added support to add money to cards. I'm attaching a new diff file
        Hide
        Mark Spencer added a comment -

        Looks good to me, added to CVS, thanks!

        Show
        Mark Spencer added a comment - Looks good to me, added to CVS, thanks!

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development