| Summary: | ASTERISK-23504: [patch] MESSAGE string is not present in allowed methods in SIP header | ||
| Reporter: | Martin Kontsek (martinkontsek) | Labels: | |
| Date Opened: | 2014-03-19 11:16:23 | Date Closed: | 2014-03-27 22:50:47 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Messaging |
| Versions: | 11.8.1 | Frequency of Occurrence | Constant |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) sip.h_patch.diff | |
| Description: | Some SIP clients like Jitsi won't allow to send SIP SIMPLE message, when there isn't MESSAGE present in SIP header in Allowed methods. | ||
| Comments: | By: Martin Kontsek (martinkontsek) 2014-03-19 11:21:52.943-0500 This patch to sip.h adds MESSAGE to allowed methods in SIP header. By: Matt Jordan (mjordan) 2014-03-25 09:36:34.157-0500 Just as an FYI, Asterisk doesn't support SIMPLE. While Asterisk should probably be advertising support for MESSAGE requests - as a MESSAGE request is not the same things as SIMPLE - adding that to the allowed headers will probably not actually do everything that you may be looking for. By: Martin Kontsek (martinkontsek) 2014-03-25 09:58:06.051-0500 Well, when I apply the patch I submited, Jitsi can send messages using SIP protocol. Without it, it can only recieve. By: Rusty Newton (rnewton) 2014-03-25 13:22:05.361-0500 Despite it being a very simple patch, Martin, can you post the patch on Reviewboard (see general [code review process here|https://wiki.asterisk.org/wiki/display/AST/Code+Review]) just to get some peer review. By: Matt Jordan (mjordan) 2014-03-27 22:50:47.833-0500 Reported by: Martin Kontsek By: Matt Jordan (mjordan) 2014-03-27 22:50:48.216-0500 Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587) By: Matt Jordan (mjordan) 2014-03-27 22:53:46.915-0500 Reported by: Martin Kontsek By: Matt Jordan (mjordan) 2014-03-27 22:53:47.308-0500 Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587) By: Matt Jordan (mjordan) 2014-03-27 22:56:05.458-0500 So, smart commits are annoying. :-( I may have to not use the #comment feature for this... By: Matt Jordan (mjordan) 2014-03-27 22:56:48.217-0500 Reported by: Martin Kontsek By: Matt Jordan (mjordan) 2014-03-27 22:56:48.575-0500 Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587) By: Matt Jordan (mjordan) 2014-03-27 22:56:49.477-0500 Reported by: Martin Kontsek By: Matt Jordan (mjordan) 2014-03-27 22:56:49.853-0500 Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587) | ||