| Summary: | ASTERISK-23592: [patch]Improvements to chan_unistim | ||
| Reporter: | Peter Whisker (whiskerp) | Labels: | |
| Date Opened: | 2014-04-06 08:46:24 | Date Closed: | 2014-04-28 10:32:05 |
| Priority: | Minor | Regression? | |
| Status: | Closed/Complete | Components: | Channels/chan_unistim |
| Versions: | SVN | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) ASTERISK-23592-1.diff ( 1) chan_unistim.c.diff ( 2) chan_unistim.c.diff | |
| Description: | I have been actively testing Unistim devices (i2002 & i2004) and have encountered issues with
1) dialtone wrong 2) inability to select DTMF playback duration 3) inability to set date to match than of a Nortel CS1000 4) mute causing playback to be muted as well as microphone 5) Timer displayed in French (Duree) The attached patch fixes as follows: 1) The "modulation" should not be referenced for tone+tone as it refers to the on-off characteristic I believe - this often resulted in a single tone rather than the multitone as in the UK. 2) I have added the unistim.conf variable dtmf_duration which can select the DTMF playback duration from 0ms to 150ms (0 is off and is the new default) 3) I have enabled the transmission of MonthLabels (in English) which are sent with the date and changed the dateformat variable to accept the values 0-3 as per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 4) I have enabled the "Mute" packet and merged it into the previous code. It now only mutes the microphone. (Improvements welcome) 5) Changed Duree to Timer on i2004 display | ||
| Comments: | By: Peter Whisker (whiskerp) 2014-04-08 09:00:15.955-0500 Corrected this line in the patch to configs/unistim.conf.sample: +;dateformat=0 ; 0 (default) = 31Jan, 1 = Jan31, 2 = month/day, 3 = day/month It mistakenly had two "3 =" entries. By: Rusty Newton (rnewton) 2014-04-09 09:57:30.346-0500 Igor will likely be the primary person reviewing your code, however if you like, you can also use reviewboard.asterisk.org to facilitate the review process. Our overall code review process has recently been updated and is described on the [wiki at this link|https://wiki.asterisk.org/wiki/display/AST/Code+Review]. We still like to have a JIRA issue associated to the submission, but the reviewboard tool is designed for reviews. You can reference the reviewboard issue within the JIRA issue by editing this issue and finding the appropriate field. Using reviewboard, may even make it easier for Igor to provide targeted feedback on sections of your code. Thanks! By: Peter Whisker (whiskerp) 2014-04-09 10:31:13.314-0500 Submitted to Review Board (#3430) By: Igor Goncharovsky (igorg) 2014-04-21 01:55:07.577-0500 I'll ship it with corrections related to chan_unistim internationalization. Thank you for your input! By: Igor Goncharovsky (igorg) 2014-04-22 00:12:13.022-0500 Peter, I have attached pathc with my changes, please test it. Changes made: - Improved muting, so mute key operate independent of call and screen state - Added translation support for month labels | ||