| Summary: | ASTERISK-23628: chan_unistim.c: 2 * bad if tests | ||
| Reporter: | dcb314 (dcb314) | Labels: | |
| Date Opened: | 2014-04-14 03:19:20 | Date Closed: | 2014-04-29 15:54:51 |
| Priority: | Major | Regression? | |
| Status: | Closed/Complete | Components: | |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | All | Attachments: | |
| Description: | [chan_unistim.c:1230]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5.
Source code is if ((fav < 0) && (fav > 5)) { \[EDIT: mjordan\] Removed inline patch. [chan_unistim.c:1244]: (warning) Logical conjunction always evaluates to false: fav < 0 && fav > 5. Duplicate. | ||
| Comments: | By: Matt Jordan (mjordan) 2014-04-14 07:12:48.654-0500 We can't accept inline patches in issues, even if the patch is trivial. Please sign a license contributor agreement and attach the patch in unified diff format to this issue. Instructions for submitting a patch can be found on the wiki: https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process By: dcb314 (dcb314) 2014-04-14 07:32:41.501-0500 >We can't accept inline patches in issues, even if the patch is trivial. Righto. >Please sign a license contributor agreement and attach the patch in unified diff format to this issue. Sorry, no. I find bugs, other folks with more knowledge of the project are better placed to fix them. | ||