| Summary: | ASTERISK-23657: Monitor: Kill with Fire. | ||||
| Reporter: | Matt Jordan (mjordan) | Labels: | |||
| Date Opened: | 2014-04-23 09:41:45 | Date Closed: | 2022-02-14 13:43:45.000-0600 | ||
| Priority: | Major | Regression? | |||
| Status: | Closed/Complete | Components: | Resources/res_monitor | ||
| Versions: | SVN 13.18.4 | Frequency of Occurrence | |||
| Related Issues: |
| ||||
| Environment: | Attachments: | ||||
| Description: | There's really no reason for Monitor any more. With MixMonitor's 'r' and 't' options, MixMonitor can perform everything Monitor does, and it does it in a much more effective fashion.
Problems with Monitor: # It uses Optional API. Optional API breaks things. # It still sits in {{channel.c}}. Every thing we do in {{ast_write}} takes time. # It doesn't use framehooks. # It is executed by the thread writing frames. Writing to disk on that thread is bad. Rip it out. Kill with fire. But don't break compatibility! Instead, res_monitor should map it's callbacks to app_mixmonitor. Or app_mixmonitor should just provide Monitor as well and call MixMonitor under the hood. Features callbacks should do that as well. | ||||
| Comments: | By: Rusty Newton (rnewton) 2014-04-25 09:48:18.661-0500 Yes please. I still see people asking which one to use. By: Joshua C. Colp (jcolp) 2022-02-14 13:43:45.386-0600 Deprecated, will be removed in future. | ||||